Re: [PATCH v3] libiberty: Use posix_spawn in pex-unix when available.

[Jeff Law <jeffreyalaw@gmail.com>]

On 10/4/23 12:28, Brendan Shanks wrote:
> Hi,
> 
> This patch implements pex_unix_exec_child using posix_spawn when
> available.
> 
> This should especially benefit recent macOS (where vfork just calls
> fork), but should have equivalent or faster performance on all
> platforms.
> In addition, the implementation is substantially simpler than the
> vfork+exec code path.
> 
> Tested on x86_64-linux.
> 
> v2: Fix error handling (previously the function would be run twice in
> case of error), and don't use a macro that changes control flow.
> 
> v3: Match file style for error-handling blocks, don't close
> in/out/errdes on error, and check close() for errors.
> 
> libiberty/
> 	* configure.ac (AC_CHECK_HEADERS): Add spawn.h.
> 	(checkfuncs): Add posix_spawn, posix_spawnp.
> 	(AC_CHECK_FUNCS): Add posix_spawn, posix_spawnp.
> 	* configure, config.in: Rebuild.
> 	* pex-unix.c [HAVE_POSIX_SPAWN] (pex_unix_exec_child): New function.
Thanks.  I pushed this based on Richi's ACK after fixing some minor 
whitespace problems and rebuilding the generated files.

Sorry about the long delay.

jeff