Re: [PATCH][libgomp, nvptx] Fix hang in gomp_team_barrier_wait_end

[Tom de Vries <tdevries@suse.de>]

On 5/20/21 11:52 AM, Thomas Schwinge wrote:
> Hi Tom!
> 
> First, thanks for looking into this PR99555!
> 
> 
> I can't comment on the OpenMP/nvptx changes, so just the following:
> 
> On 2021-04-23T18:48:01+0200, Tom de Vries <tdevries@suse.de> wrote:
>> --- a/libgomp/testsuite/libgomp.fortran/task-detach-6.f90
>> +++ b/libgomp/testsuite/libgomp.fortran/task-detach-6.f90
>> @@ -1,6 +1,5 @@
>>  ! { dg-do run }
>>
>> -! { dg-additional-sources on_device_arch.c }
>>    ! { dg-prune-output "command-line option '-fintrinsic-modules-path=.*' is valid for Fortran but not for C" }
> 
> Please remove the 'dg-prune-output', too.  ;-)
> 

Ack, updated patch.

> Your changes leave
> 'libgomp/testsuite/lib/libgomp.exp:check_effective_target_offload_device_nvptx',
> 'libgomp/testsuite/libgomp.c-c++-common/on_device_arch.h',
> 'libgomp/testsuite/libgomp.fortran/on_device_arch.c' unused.  Should we
> keep those for a potential future use (given that they've been tested to
> work) or remove (as now unused, danger of bit-rot)?

I vote to leave them in, they look useful, and I think the danger of
bit-rot is less than the danger of not knowing/remembering that they
once where there and having to start from scratch.

Thanks,
- Tom