From: Jeff Law <law@redhat.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org, andrew.n.senkevich@gmail.com
Subject: Re: [PATCH] Fix PR78306
Date: Tue, 29 Nov 2016 16:52:00 -0000 [thread overview]
Message-ID: <7e9c05f1-a4d6-2a79-7c03-0219c90cf134@redhat.com> (raw)
In-Reply-To: <alpine.LSU.2.11.1611290844280.5294@t29.fhfr.qr>
On 11/29/2016 12:47 AM, Richard Biener wrote:
>> Balaji added this check explicitly. There should be tests in the testsuite
>> (spawnee_inline, spawner_inline) which exercise that code.
>
> Yes he did, but no, nothing in the testsuite.
I believe the tests are:
c-c++-common/cilk-plus/CK/spawnee_inline.c
c-c++-common/cilk-plus/CK/spawner_inline.c
But as I mentioned, they don't check for proper behaviour
>
> There is _nowhere_ documented _why_ the checks were added. Why is
> inlining a transform that can do anything bad to a function using
> cilk_spawn?
I know, it's disappointing. Even the tests mentioned above don't shed
any real light on the issue.
Jeff
next prev parent reply other threads:[~2016-11-29 16:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 14:58 Richard Biener
2016-11-16 9:43 ` Richard Biener
2016-11-29 0:09 ` Jeff Law
2016-11-29 7:47 ` Richard Biener
2016-11-29 16:52 ` Jeff Law [this message]
2016-11-30 8:52 ` Richard Biener
2016-11-30 12:19 ` Andrew Senkevich
2016-11-30 14:18 ` Richard Biener
2016-12-02 21:35 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e9c05f1-a4d6-2a79-7c03-0219c90cf134@redhat.com \
--to=law@redhat.com \
--cc=andrew.n.senkevich@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).