From: "Martin Liška" <mliska@suse.cz>
To: Indu Bhagat <indu.bhagat@oracle.com>, gcc-patches@gcc.gnu.org
Cc: Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH] PR86957
Date: Mon, 17 Sep 2018 10:10:00 -0000 [thread overview]
Message-ID: <7ed25f0a-10a8-3eca-c032-29e76054bfb6@suse.cz> (raw)
In-Reply-To: <159a29c5-8f8b-4194-dbea-1c9bd414db3a@oracle.com>
On 9/16/18 12:58 AM, Indu Bhagat wrote:
> Thanks for the reviews. I have incorporated them in this patch except the one
> (changes in common.opt) below.
>
> In this patch,
>
> 1. -Wmissing-profile is a warning by default and is ON by default with
> -fprofile-use
> 2. Attached pr86957-missing-profile-diagnostic-2 shows the warning messages
> 3. Added a testcase for warning in the case of missing profile feedback data
> file for a compilation unit
>
> Thanks
Hi.
The patch looks fine for me now. Honza can you approve it?
Martin
>
> gcc/ChangeLog:
>
> 2018-09-14 "Indu Bhagat" <"indu.bhagat@oracle.com">
>
> * common.opt: New warning option -Wmissing-profile.
> * coverage.c (get_coverage_counts): Add warning for missing .gcda file.
> * doc/invoke.texi: Document -Wmissing-profile.
>
> gcc/testsuite/ChangeLog:
>
> 2018-09-14 "Indu Bhagat" <"indu.bhagat@oracle.com">
>
> * gcc.dg/Wmissing-profile.c: New test.
>
>
> On 09/11/2018 02:21 AM, Martin Liška wrote:
>>> --- a/gcc/common.opt
>>> +++ b/gcc/common.opt
>>> @@ -811,6 +811,10 @@ Wcoverage-mismatch
>>> Common Var(warn_coverage_mismatch) Init(1) Warning
>>> Warn in case profiles in -fprofile-use do not match.
>>>
>>> +Wmissing-profile
>>> +Common Var(warn_missing_profile) Init(1) Warning
>>> +Warn in case profiles in -fprofile-use do not exist.
>> Maybe 'Want about missing profile for a function in -fprofile-use build.' ?
>>
> Since, it also warns when feedback file is missing for a compilation unit, the
> suggested text above will be more restrictive. So I did not change.
>
>
next prev parent reply other threads:[~2018-09-17 10:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 19:29 Indu Bhagat
2018-09-11 9:21 ` Martin Liška
2018-09-16 8:28 ` Indu Bhagat
[not found] ` <159a29c5-8f8b-4194-dbea-1c9bd414db3a@oracle.com>
2018-09-17 10:10 ` Martin Liška [this message]
2018-09-17 11:20 ` Jan Hubicka
2018-09-18 19:41 ` Indu Bhagat
2018-09-21 23:23 ` Indu Bhagat
2018-09-24 16:46 ` Martin Sebor
2018-09-24 19:16 ` Indu Bhagat
2018-09-26 9:23 ` Martin Liška
2018-09-27 10:02 ` Richard Biener
2018-09-27 10:15 ` Martin Liška
2018-09-27 13:13 ` Martin Liška
2018-09-27 14:58 ` Richard Biener
2018-12-05 11:33 ` Thomas Schwinge
2018-12-07 1:46 ` Indu Bhagat
2018-12-10 20:45 ` Indu Bhagat
2018-12-11 9:14 ` Thomas Schwinge
2018-12-04 15:33 ` [committed, testsuite] Fix PR88310 Iain Sandoe
2018-09-11 9:23 ` [PATCH] PR86957 Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ed25f0a-10a8-3eca-c032-29e76054bfb6@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=indu.bhagat@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).