public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] PR86957
@ 2018-09-05 19:29 Indu Bhagat
  2018-09-11  9:21 ` Martin Liška
  2018-09-11  9:23 ` [PATCH] PR86957 Martin Liška
  0 siblings, 2 replies; 20+ messages in thread
From: Indu Bhagat @ 2018-09-05 19:29 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]

Patch for PR 86957 " gcc should warn about missing profiles for a compilation unit or a new function with -fprofile-use".
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86957

The patch adds -Wmissing-profile warning flag to alert user about cases when there is no profile data for a compilation unit or a function when using -fprofile-use.

The flag is on by default when -fprofile-use is specified and generates errors
by default (like -Wcoverage-mismatch).

The attachment pr86957-missing-profile-diagnostic shows the behavior of GCC with the patch.

Thanks
Indu

------------------------------------------------------


gcc/ChangeLog:

2018-09-05  "Indu Bhagat"  <"indu.bhagat@oracle.com">

         * common.opt: New warning option -Wmissing-profile.
         * coverage.c (get_coverage_counts): Add warning for missing .gcda file.
         * doc/invoke.texi: Document -Wmissing-profile.
         * profile.c (get_exec_counts): Add warning for missing feedback
           profile for a function.
         * toplev.c (process_options): -Wmissing-profile warning as error.


[-- Attachment #2: pr86957-patch --]
[-- Type: text/plain, Size: 6710 bytes --]

diff --git a/gcc/common.opt b/gcc/common.opt
index ebc3ef4..d93ddca 100644
--- a/gcc/common.opt
+++ b/gcc/common.opt
@@ -811,6 +811,10 @@ Wcoverage-mismatch
 Common Var(warn_coverage_mismatch) Init(1) Warning
 Warn in case profiles in -fprofile-use do not match.
 
+Wmissing-profile
+Common Var(warn_missing_profile) Init(1) Warning
+Warn in case profiles in -fprofile-use do not exist.
+
 Wvector-operation-performance
 Common Var(warn_vector_operation_performance) Warning
 Warn when a vector operation is compiled outside the SIMD.
diff --git a/gcc/coverage.c b/gcc/coverage.c
index bae6f5c..df031df 100644
--- a/gcc/coverage.c
+++ b/gcc/coverage.c
@@ -341,16 +341,24 @@ get_coverage_counts (unsigned counter, unsigned expected,
     {
       static int warned = 0;
 
-      if (!warned++ && dump_enabled_p ())
+      if (!warned++)
 	{
-	  dump_user_location_t loc
-	    = dump_user_location_t::from_location_t (input_location);
-	  dump_printf_loc (MSG_OPTIMIZED_LOCATIONS, loc,
+	  warning (OPT_Wmissing_profile,
+		   "%qs profile count data file not found,"
+		   " regenerating profiles may help",
+		   da_file_name);
+	  if (dump_enabled_p ())
+	    {
+	      dump_user_location_t loc
+		= dump_user_location_t::from_location_t (input_location);
+	      dump_printf_loc (MSG_OPTIMIZED_LOCATIONS, loc,
+			       "file %s not found\n",
+			       da_file_name);
+	      dump_printf (MSG_OPTIMIZED_LOCATIONS,
 			   (flag_guess_branch_prob
-			    ? "file %s not found, execution counts estimated\n"
-			    : "file %s not found, execution counts assumed to "
-			    "be zero\n"),
-			   da_file_name);
+			    ? "execution counts estimated\n"
+			    : "execution counts assumed to be zero\n"));
+	    }
 	}
       return NULL;
     }
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index ca92028..e62bcae 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -314,7 +314,7 @@ Objective-C and Objective-C++ Dialects}.
 -Wlogical-op  -Wlogical-not-parentheses  -Wlong-long @gol
 -Wmain  -Wmaybe-uninitialized  -Wmemset-elt-size  -Wmemset-transposed-args @gol
 -Wmisleading-indentation  -Wmissing-attributes -Wmissing-braces @gol
--Wmissing-field-initializers  -Wmissing-include-dirs @gol
+-Wmissing-field-initializers  -Wmissing-include-dirs  -Wmissing-profile @gol
 -Wno-multichar  -Wmultistatement-macros  -Wnonnull  -Wnonnull-compare @gol
 -Wnormalized=@r{[}none@r{|}id@r{|}nfc@r{|}nfkc@r{]} @gol
 -Wnull-dereference  -Wodr  -Wno-overflow  -Wopenmp-simd  @gol
@@ -4816,6 +4816,25 @@ This warning is enabled by @option{-Wall}.
 @opindex Wno-missing-include-dirs
 Warn if a user-supplied include directory does not exist.
 
+@item -Wmissing-profile
+@opindex Wmissing-profile
+@opindex Wno-missing-profile
+Warn if feedback profiles are missing when using the
+@option{-fprofile-use} option.
+If a new function or a new file is added to the user code between compiling
+with @option{-fprofile-gen} and with @option{-fprofile-use} without
+regenerating the profiles, the profile feedback data files do not contain any
+profile feedback information for the newly
+added function or file respectively.  Also, in the case when profile count data
+(.gcda) files are wiped out, GCC cannot use any profile feedback
+information.  In all these cases, warnings are issued to inform the user that a
+profile generation step is due.  By default, this warning is enabled and is
+treated as an error.  @option{-Wno-missing-profile} can be used to disable the
+warning or @option{-Wno-error=missing-profile} can be used to disable the
+error.  Disabling the error for this warning can result in poorly optimized
+code and is useful only in the cases when non-existent profile data is
+justified.  Completely disabling the warning is not recommended.
+
 @item -Wmultistatement-macros
 @opindex Wmultistatement-macros
 @opindex Wno-multistatement-macros
@@ -9899,8 +9918,10 @@ Before you can use this option, you must first generate profiling information.
 
 By default, GCC emits an error message if the feedback profiles do not
 match the source code.  This error can be turned into a warning by using
-@option{-Wcoverage-mismatch}.  Note this may result in poorly optimized
-code.
+@option{-Wno-error=coverage-mismatch}.  Note this may result in poorly
+optimized code.  Additionally, by default, GCC also emits an error message if
+the feedback profiles do not exist.  The latter error can be turned into a
+warning by using @option{-Wno-error=missing-profile}.
 
 If @var{path} is specified, GCC looks at the @var{path} to find
 the profile feedback data files. See @option{-fprofile-dir}.
diff --git a/gcc/profile.c b/gcc/profile.c
index cb51e0d..40f9763 100644
--- a/gcc/profile.c
+++ b/gcc/profile.c
@@ -286,7 +286,13 @@ get_exec_counts (unsigned cfg_checksum, unsigned lineno_checksum)
   counts = get_coverage_counts (GCOV_COUNTER_ARCS, num_edges, cfg_checksum,
 				lineno_checksum, &profile_info);
   if (!counts)
-    return NULL;
+    {
+      warning (OPT_Wmissing_profile,
+	       "profile for function %qE not found in profile data,"
+	       " regenerating profiles may help",
+	       DECL_ASSEMBLER_NAME (current_function_decl));
+      return NULL;
+    }
 
   get_working_sets ();
 
diff --git a/gcc/toplev.c b/gcc/toplev.c
index 9fb83d4..5891554 100644
--- a/gcc/toplev.c
+++ b/gcc/toplev.c
@@ -1782,14 +1782,24 @@ process_options (void)
       || !targetm.have_prologue () || !targetm.have_epilogue ())
     flag_ipa_ra = 0;
 
-  /* Enable -Werror=coverage-mismatch when -Werror and -Wno-error
-     have not been set.  */
-  if (!global_options_set.x_warnings_are_errors
-      && warn_coverage_mismatch
-      && (global_dc->classify_diagnostic[OPT_Wcoverage_mismatch] ==
-          DK_UNSPECIFIED))
-    diagnostic_classify_diagnostic (global_dc, OPT_Wcoverage_mismatch,
-                                    DK_ERROR, UNKNOWN_LOCATION);
+  if (!global_options_set.x_warnings_are_errors)
+    {
+      /* Enable -Werror=coverage-mismatch when -Werror and -Wno-error
+	 have not been set.  */
+      if (warn_coverage_mismatch
+	  && (global_dc->classify_diagnostic[OPT_Wcoverage_mismatch] ==
+	      DK_UNSPECIFIED))
+	diagnostic_classify_diagnostic (global_dc, OPT_Wcoverage_mismatch,
+					DK_ERROR, UNKNOWN_LOCATION);
+
+      /* Enable -Werror=missing-profile when -Werror and -Wno-error
+	 have not been set.  */
+      if (warn_missing_profile
+	  && (global_dc->classify_diagnostic[OPT_Wmissing_profile] ==
+	      DK_UNSPECIFIED))
+	diagnostic_classify_diagnostic (global_dc, OPT_Wmissing_profile,
+					DK_ERROR, UNKNOWN_LOCATION);
+    }
 
   /* Save the current optimization options.  */
   optimization_default_node = build_optimization_node (&global_options);

[-- Attachment #3: pr86957-missing-profile-diagnostic --]
[-- Type: text/plain, Size: 2736 bytes --]

[Testcase 1] Missing profile data file with -fprofile-use. The sort.c file contains two functions main() and stop()

gcc -c sort.c -fprofile-use -O1 -fprofile-dir=/data2/user/gcc-temp/fdo/profdata/
sort.c: In function ‘main’:
sort.c:29:1: error: ‘/data2/user/gcc-temp/fdo/profdata//#data2#user#gcc-temp#fdo#sort.gcda’ profile count data file not found, regenerating profiles may help [-Werror=missing-profile]
29 | }
   | ^
sort.c:29:1: error: profile for function ‘main’ not found in profile data, regenerating profiles may help [-Werror=missing-profile]
sort.c: In function ‘stop’:
sort.c:29:1: error: profile for function ‘stop’ not found in profile data, regenerating profiles may help [-Werror=missing-profile]
cc1: some warnings being treated as errors
make: *** [sort.o] Error 1

[Testcase 2] bubble_sort.c has a non-empty function bubble_sort() for which profile data exists.
Now at profile-use phase, a user adds empty function before1() before an existing lone function bubble_sort() and empty function after1() after the lone existing function bubble_sort()

gcc -c bubble_sort.c -fprofile-use -O1 -fprofile-dir=/data2/user/gcc-temp/fdo/profdata/
bubble_sort.c: In function ‘after1’:
bubble_sort.c:19:1: error: profile for function ‘after1’ not found in profile data, regenerating profiles may help [-Werror=missing-profile]
19 | void after1() { }
   | ^~~~
bubble_sort.c: In function ‘bubble_sort’:
bubble_sort.c:19:1: error: source locations for function ‘bubble_sort’ have changed, the profile data may be out of date [-Werror=coverage-mismatch]
bubble_sort.c: In function ‘before1’:
bubble_sort.c:19:1: error: profile for function ‘before1’ not found in profile data, regenerating profiles may help [-Werror=missing-profile]
cc1: some warnings being treated as errors
make: *** [bubble_sort.o] Error 1

[Testcase 3] Use -Wno-error=missing-profile to treat them as warnings, not errors

gcc -c bubble_sort.c -fprofile-use -O1 -Wno-error=missing-profile -fprofile-dir=/data2/user/gcc-temp/fdo/profdata/
bubble_sort.c: In function ‘after1’:
bubble_sort.c:19:1: warning: profile for function ‘after1’ not found in profile data, regenerating profiles may help [-Wmissing-profile]
19 | void after1() { }
   | ^~~~
bubble_sort.c: In function ‘bubble_sort’:
bubble_sort.c:19:1: error: source locations for function ‘bubble_sort’ have changed, the profile data may be out of date [-Werror=coverage-mismatch]
bubble_sort.c: In function ‘before1’:
bubble_sort.c:19:1: warning: profile for function ‘before1’ not found in profile data, regenerating profiles may help [-Wmissing-profile]
cc1: some warnings being treated as errors
make: *** [bubble_sort.o] Error 1 

^ permalink raw reply	[flat|nested] 20+ messages in thread
end of thread, other threads:[~2018-12-11  9:14 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-05 19:29 [PATCH] PR86957 Indu Bhagat
2018-09-11  9:21 ` Martin Liška
2018-09-16  8:28   ` Indu Bhagat
     [not found]   ` <159a29c5-8f8b-4194-dbea-1c9bd414db3a@oracle.com>
2018-09-17 10:10     ` Martin Liška
2018-09-17 11:20       ` Jan Hubicka
2018-09-18 19:41         ` Indu Bhagat
2018-09-21 23:23         ` Indu Bhagat
2018-09-24 16:46           ` Martin Sebor
2018-09-24 19:16             ` Indu Bhagat
2018-09-26  9:23               ` Martin Liška
2018-09-27 10:02               ` Richard Biener
2018-09-27 10:15                 ` Martin Liška
2018-09-27 13:13                   ` Martin Liška
2018-09-27 14:58                     ` Richard Biener
2018-12-05 11:33                 ` Thomas Schwinge
2018-12-07  1:46                   ` Indu Bhagat
2018-12-10 20:45                     ` Indu Bhagat
2018-12-11  9:14                       ` Thomas Schwinge
2018-12-04 15:33               ` [committed, testsuite] Fix PR88310 Iain Sandoe
2018-09-11  9:23 ` [PATCH] PR86957 Martin Liška

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).