* [committed] epiphany: Fix up epiphany_setup_incoming_varargs [PR114175]
@ 2024-03-20 16:05 Jakub Jelinek
2024-03-20 16:59 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2024-03-20 16:05 UTC (permalink / raw)
To: gcc-patches
Hi!
Like for x86-64, alpha or rs6000, epiphany seems to be affected too.
Just visually checked differences in c23-stdarg-9.c assembly in a cross
without/with the patch, committed to trunk.
2024-03-20 Jakub Jelinek <jakub@redhat.com>
PR target/114175
* config/epiphany/epiphany.cc (epiphany_setup_incoming_varargs): Only
skip function arg advance for TYPE_NO_NAMED_ARGS_STDARG_P functions
if arg.type is NULL.
--- gcc/config/epiphany/epiphany.cc.jj 2024-01-03 11:51:47.401510931 +0100
+++ gcc/config/epiphany/epiphany.cc 2024-03-20 16:10:08.152226880 +0100
@@ -728,7 +728,8 @@ epiphany_setup_incoming_varargs (cumulat
gcc_assert (arg.mode != BLKmode);
next_cum = *get_cumulative_args (cum);
- if (!TYPE_NO_NAMED_ARGS_STDARG_P (TREE_TYPE (current_function_decl)))
+ if (!TYPE_NO_NAMED_ARGS_STDARG_P (TREE_TYPE (current_function_decl))
+ || arg.type != NULL_TREE)
next_cum = (ROUND_ADVANCE_CUM (next_cum, arg.mode, arg.type)
+ ROUND_ADVANCE_ARG (arg.mode, arg.type));
first_anon_arg = next_cum;
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [committed] epiphany: Fix up epiphany_setup_incoming_varargs [PR114175]
2024-03-20 16:05 [committed] epiphany: Fix up epiphany_setup_incoming_varargs [PR114175] Jakub Jelinek
@ 2024-03-20 16:59 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2024-03-20 16:59 UTC (permalink / raw)
To: Jakub Jelinek, gcc-patches
On 3/20/24 10:05 AM, Jakub Jelinek wrote:
> Hi!
>
> Like for x86-64, alpha or rs6000, epiphany seems to be affected too.
>
> Just visually checked differences in c23-stdarg-9.c assembly in a cross
> without/with the patch, committed to trunk.
>
> 2024-03-20 Jakub Jelinek <jakub@redhat.com>
>
> PR target/114175
> * config/epiphany/epiphany.cc (epiphany_setup_incoming_varargs): Only
> skip function arg advance for TYPE_NO_NAMED_ARGS_STDARG_P functions
> if arg.type is NULL.
Built fine. Platform has been too flakey to run tests with any
consistency. So no real test results.
jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-20 16:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-20 16:05 [committed] epiphany: Fix up epiphany_setup_incoming_varargs [PR114175] Jakub Jelinek
2024-03-20 16:59 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).