From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 73F58387057C; Fri, 9 Dec 2022 01:51:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 73F58387057C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B90IxSh014434; Fri, 9 Dec 2022 01:51:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : mime-version : content-type; s=pp1; bh=rBMMH5x229gV4zrOJU2EaaFrqOgQIXvWNnFxeKbW1U4=; b=kCRAxfMkWZy8yrD2pReZV47YQGfx8jUMZP45YN2B6FlFtJl7gCkg4CT9mBSOvKtlscFb 6mOl8ij8L/0SMF++96j0kVydeL1Oq+tZ8d6hMfhWAXvelk5Fo+wmOXciJtypKGUDCBgE 4FwzIuD4bl2hYI2Iu7xtdqJKvVOTp/IFfBsQ9Ca0amU/s+gBeePHqTrUvN60veHp8yuu TSY/gUYXcpQEcDM0f7pmDa9r670I9g1y4yMkiKS6ya/VEZGHI/NMf0rXmSgBrfPwYc17 6ZHcDzpvbPl+WJ5Xx1b9AKYuHS7IRNzXyu03b0qWOo7upRb0zsAXesoof0R0dytgAm90 Dw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3mbjsrvxqf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Dec 2022 01:51:21 +0000 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2B91pKbS007920; Fri, 9 Dec 2022 01:51:20 GMT Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3mbjsrvxqa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Dec 2022 01:51:20 +0000 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.17.1.19/8.16.1.2) with ESMTP id 2B8NTVN8004171; Fri, 9 Dec 2022 01:51:19 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([9.208.130.100]) by ppma04dal.us.ibm.com (PPS) with ESMTPS id 3m9sjt8h0d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Dec 2022 01:51:19 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2B91pI3458786164 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 9 Dec 2022 01:51:18 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 876E25805F; Fri, 9 Dec 2022 01:51:18 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4EFF358061; Fri, 9 Dec 2022 01:51:18 +0000 (GMT) Received: from pike (unknown [9.5.12.127]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTPS; Fri, 9 Dec 2022 01:51:18 +0000 (GMT) From: Jiufu Guo To: Jiufu Guo via Gcc-patches Cc: "Kewen.Lin" , segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org Subject: Re: [PATCH 2/3]rs6000: NFC use sext_hwi to replace ((v&0xf..f)^0x80..0) - 0x80..0 References: <20221201013619.196004-1-guojiufu@linux.ibm.com> <20221201013619.196004-2-guojiufu@linux.ibm.com> <94338e4c-baf4-ec09-68a7-064a23c79327@linux.ibm.com> <9cbc0b3d-0d4b-5646-0ed8-fa2d4f8dc8c3@linux.ibm.com> <81db0995-8ba5-766c-1e0e-67d3d47c40ce@linux.ibm.com> <3f42f78c-7b28-02b8-6e78-17819f784979@linux.ibm.com> <7er0xev0q3.fsf@pike.rch.stglabs.ibm.com> Date: Fri, 09 Dec 2022 09:51:15 +0800 In-Reply-To: <7er0xev0q3.fsf@pike.rch.stglabs.ibm.com> (Jiufu Guo via Gcc-patches's message of "Mon, 05 Dec 2022 14:11:32 +0800") Message-ID: <7ek031mjjg.fsf@pike.rch.stglabs.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 5ezgOR68nv-C00JjwSNauuqMaTbEylsc X-Proofpoint-ORIG-GUID: dwJc2WPffTotlfGM4E2LisgxsaejXx6y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-08_12,2022-12-08_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 mlxlogscore=558 priorityscore=1501 clxscore=1015 phishscore=0 malwarescore=0 spamscore=0 mlxscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212090010 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Jiufu Guo via Gcc-patches writes: > Hi Kewen, > > "Kewen.Lin" writes: >> on 2022/12/1 20:16, guojiufu wrote: >>> On 2022-12-01 15:10, Jiufu Guo via Gcc-patches wrote: >>>> Hi Kewen, cut... >>> From 8aa8e1234b6ec34473434951a3a6177253aac770 Mon Sep 17 00:00:00 2001 >>> From: Jiufu Guo >>> Date: Wed, 30 Nov 2022 13:13:37 +0800 >>> Subject: [PATCH 2/2]rs6000: update ((v&0xf..f)^0x80..0) - 0x80..0 with code: like sext_hwi >>> >> >> May be shorter with "rs6000: Update sign extension computation with >> sext_hwi"? > Thanks for your great suggestions! >> >>> This patch just replaces the expression like: >>> ((value & 0xf..f) ^ 0x80..0) - 0x80..0 to better code(e.g. sext_hwi) for >>> rs6000.cc, rs6000.md and predicates.md (files under rs6000/). >> >> >>> Bootstrap and regtest pass on ppc64{,le}. >>> >> >> Thanks for updating and testing, this patch is OK. Committed via r13-4556. Thanks again! BR, Jeff (Jiufu) > > BR, > Jeff (Jiufu) > >> >> BR, >> Kewen