From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id C90E23945C20; Tue, 6 Dec 2022 02:03:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C90E23945C20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B60OKqr011994; Tue, 6 Dec 2022 02:03:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : mime-version : content-type; s=pp1; bh=eQcQA7d94c8wCulBd4d7umsbMuYm6mAemVMq9oLERXM=; b=FoahuF58g2gOm2QGTtPkaUkeoynikTnmwEVihGS6gdATtNee/YmeTtMrSjGrd/iHWhSx 4kMKVMmefdgK/tzUXob8NT0MYn0UamGIXQDbgUY9aBznbRiU6Pps7P2gRL+Naejh98JI prIENmrGduubS0Jn5A6vp83l8HWlSeQjjMOYCdTfmZeVSRSZV8dOKwhHtAqOWnbBXmFP /U0jNACdwD3V4jiutpcNK3P42Z7cbP5lwnvwQU1X+3jHzT/B+f6HrvC5rg9i4dgUQG4F dP2ULRsy1MFnYk5cWmVbZKDIZyqxzrLXfA4uhJPGlQKsb99vxF+VFRcuNKuadhC0jpDj DQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3m8gm3w37h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 06 Dec 2022 02:03:36 +0000 Received: from m0098416.ppops.net (m0098416.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2B61Ni5U025833; Tue, 6 Dec 2022 02:03:35 GMT Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3m8gm3w379-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 06 Dec 2022 02:03:35 +0000 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 2B5NGKER027796; Tue, 6 Dec 2022 01:58:34 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([9.208.129.119]) by ppma01wdc.us.ibm.com (PPS) with ESMTPS id 3m9pqg1qx0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 06 Dec 2022 01:58:34 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2B61wXKE38732430 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 6 Dec 2022 01:58:33 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 78B0E5805A; Tue, 6 Dec 2022 01:58:33 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3713358060; Tue, 6 Dec 2022 01:58:33 +0000 (GMT) Received: from pike (unknown [9.5.12.127]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTPS; Tue, 6 Dec 2022 01:58:33 +0000 (GMT) From: Jiufu Guo To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, rguenther@suse.de, jeffreyalaw@gmail.com Subject: Re: [PATCH 3/3] Testcases for move sub blocks on param and ret References: <20221129134507.185951-1-guojiufu@linux.ibm.com> <20221129134507.185951-3-guojiufu@linux.ibm.com> <20221205193943.GX25951@gate.crashing.org> Date: Tue, 06 Dec 2022 09:58:30 +0800 In-Reply-To: <20221205193943.GX25951@gate.crashing.org> (Segher Boessenkool's message of "Mon, 5 Dec 2022 13:39:43 -0600") Message-ID: <7epmcxnvi1.fsf@pike.rch.stglabs.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: hVKl2CPuRbyOXSG4NDhWdMDMFnHvqFex X-Proofpoint-GUID: cDVBAs4iuD9jFjUj7A71TSarhbF2Pfb4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-05_01,2022-12-05_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 spamscore=0 clxscore=1015 mlxscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212060012 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Segher, Thanks for your comments! Segher Boessenkool writes: > Hi! > > Some comments on the testcases: > > On Tue, Nov 29, 2022 at 09:45:07PM +0800, Jiufu Guo wrote: >> --- /dev/null >> +++ b/gcc/testsuite/gcc.target/powerpc/pr65421-1.c >> @@ -0,0 +1,25 @@ >> +/* PR target/65421 */ >> +/* { dg-do compile } */ >> +/* { dg-options "-O2" } */ >> +/* { dg-require-effective-target powerpc_elfv2 } */ >> + >> +typedef struct SA >> +{ >> + double a[3]; >> + long l; >> +} A; >> + >> +/* 2 vec load, 2 vec store. */ >> +A ret_arg_pt (A *a){return *a;} >> + >> +/* 4 std */ >> +A ret_arg (A a) {return a;} >> + >> +/* 4 std */ >> +void st_arg (A a, A *p) {*p = a;} >> + >> +/* { dg-final { scan-assembler-times {\mlxvd2x\M|\mlxv\M|\mlvx\M} 2 } } */ >> +/* { dg-final { scan-assembler-times {\mstxvd2x\M|\mstxv\M|\mstvx\M} 2 } } */ >> +/* { dg-final { scan-assembler-times {\mstd\M} 8 } } */ > > You need at least ISA 2.06 (power7) to have {l,st}xvd2x, and elfv2 does > not guarantee that. Have you tested on something old as well (say 970) > to see if the lvx/stvx is generated as expected? For that you need to > have AltiVec enabled as well, so dg-require that? Thanks a lot for point out this! Compiling this case on power7 manually, it does not generate these vector load/store insns. To check those insns, power7 is needed. > >> --- /dev/null >> +++ b/gcc/testsuite/gcc.target/powerpc/pr65421.c >> @@ -0,0 +1,22 @@ >> +/* PR target/65421 */ >> +/* { dg-do compile } */ >> +/* { dg-options "-O2" } */ >> +/* { dg-require-effective-target powerpc_elfv2 } */ >> + >> +typedef struct SA >> +{ >> + double a[3]; >> +} A; >> + >> +/* 3 lfd */ >> +A ret_arg_pt (A *a){return *a;} >> + >> +/* blr */ >> +A ret_arg (A a) {return a;} >> + >> +/* 3 stfd */ >> +void st_arg (A a, A *p) {*p = a;} >> + >> +/* { dg-final { scan-assembler-times {\mlfd\M} 3 } } */ >> +/* { dg-final { scan-assembler-times {\mstfd\M} 3 } } */ >> +/* { dg-final { scan-assembler-times {(?n)^\s+[a-z]} 9 } } */ > > Comment that last one? Just something as simple as "count insns" is > enough :-) Sure, thanks! BR, Jeff (Jiufu) > > > Segher