From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 92A973858D35 for ; Wed, 22 Nov 2023 15:05:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 92A973858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 92A973858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700665505; cv=none; b=xKZ6uiZWiIlOjAQpgS/0uyU/h18OYHWDWIXhvWHtBRT+vRc/KcLytfVamf10EjPHGFkoUE1nGwgTVGcX//rXuHfcBqAF5I4fAGEvOPrcOMY1D+2Z0zqELdsyPOv8fInomGPCYxGw/hW0GbnunR87i2lg6p3oFSWoerDsf1sMw5g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700665505; c=relaxed/simple; bh=2xV8dI4TskhshiEVb9zOu8+tqYAupTNP8AbowALaznY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=mF448X1REaqLT6Sn6mnadxMZEZVJfH7PM7DDsb847UmEmHO/JbIeiLxHGqB7/sUCMuMpW1WfZHQdZIc+PzrY+0ZLkbp8p8uvr3O6ou+u2SR6avy1fWVTW2DyhxhGzKKON7LBsmLv4vH1VM8zCq1E3TWBIvLwYLF/Al5IWmwOeDs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700665503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sq9R67z/hKVJD/8xtzgFAocs1JLSCaPxUk1AyAINlc0=; b=JdqzziAlbCwY70tIiOOLjMW+Oaf/3j20KWkT5j0xCbk5/uqHmEHDzfa3+SNfZW+6RHtdZJ LYR28tGribbS9y53o0Sy3zZsc9UaUyKrQsMkD7IjDTeFXSICi/pwtuEQjrYkdUk396FS02 OZK3O4dhjPkkvvysxqeuwFDdLH5PHUU= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-411-7kUJeZReOBmBiAuBCqd0xg-1; Wed, 22 Nov 2023 10:05:01 -0500 X-MC-Unique: 7kUJeZReOBmBiAuBCqd0xg-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-670b675b2c5so54874956d6.0 for ; Wed, 22 Nov 2023 07:05:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700665500; x=1701270300; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Sq9R67z/hKVJD/8xtzgFAocs1JLSCaPxUk1AyAINlc0=; b=LY67JO4beEy6jG2fQECsg46ROqucKAPl1DZHhJich7MX3c4hhYD9DbedaIUR1eNWMV 67KDj2zHCxvsJLg/MvQqEY9qINqwXKU5xf0VxhinLc4MV98r3IN0xTpAGm0L/BOXtpTV r5t3UwM8MY0ZOkUIWpLfAUg33xn6A9+DRRy3HsO6ITm4b5C4D/psKqY/z9bgMFoLcvV7 Tdwdcwv1dFPJQ0d+QEuLKpWoIcE7zZ4pEuuF7oRO2C35PHsn45DveJt8sh8Kevt/1qln KdOQXbnz/i15uhQYydLbHpwuljyDOYsuj3aR383JD27HeVKhge5ksV7rH0harLudBK7L 09mQ== X-Gm-Message-State: AOJu0YwExn5FP7N4iakUqCm/mZvhUjXSs3YTMWcnHFZS/MS/w+Fk20XJ gSsuMAee8yWXQB6KCULThRb2M2NgMEgPK/B/3v/6T3Cf259bSw51tY2FLYp5c5tMBEJChyiVlUc wUNCk0VO9guQAYVApnw== X-Received: by 2002:ad4:5f4c:0:b0:66d:ad78:130d with SMTP id p12-20020ad45f4c000000b0066dad78130dmr2713767qvg.21.1700665500470; Wed, 22 Nov 2023 07:05:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IFtq1Vc+ID5APRf1VEmVJZ68LzjsnMICJoDnnCpLOHLwI1+K3j6kQunHGwR5vGref32ICwlVg== X-Received: by 2002:ad4:5f4c:0:b0:66d:ad78:130d with SMTP id p12-20020ad45f4c000000b0066dad78130dmr2713739qvg.21.1700665500078; Wed, 22 Nov 2023 07:05:00 -0800 (PST) Received: from [192.168.1.88] (23-233-12-249.cpe.pppoe.ca. [23.233.12.249]) by smtp.gmail.com with ESMTPSA id cv7-20020ad44d87000000b0067169e210b3sm4909005qvb.70.2023.11.22.07.04.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Nov 2023 07:04:59 -0800 (PST) Message-ID: <7f1437ef-57aa-e81f-9db0-75611f7f4609@redhat.com> Date: Wed, 22 Nov 2023 10:04:58 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v3 2/8] Unify implementations of print_hard_reg_set() To: Maxim Kuvyrkov , gcc-patches@gcc.gnu.org Cc: Bernd Schmidt , Jeff Law , Alexander Monakov , Richard Guenther References: <20231120120649.672893-1-maxim.kuvyrkov@linaro.org> <20231122111415.815147-3-maxim.kuvyrkov@linaro.org> From: Vladimir Makarov In-Reply-To: <20231122111415.815147-3-maxim.kuvyrkov@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/22/23 06:14, Maxim Kuvyrkov wrote: > We currently have 3 implementations of print_hard_reg_set() > (all with the same name!) in ira-color.cc, ira-conflicts.cc, and > sel-sched-dump.cc. This patch generalizes implementation in > ira-color.cc, and uses it in all other places. The declaration > is added to hard-reg-set.h. > > The motivation for this patch is the [upcoming] need for > print_hard_reg_set() in sched-deps.cc. > > gcc/ChangeLog: > > * hard-reg-set.h (print_hard_reg_set): Declare. > * ira-color.cc (print_hard_reg_set): Generalize a bit. > (debug_hard_reg_set, print_hard_regs_subforest,) > (setup_allocno_available_regs_num): Update. > * ira-conflicts.cc (print_hard_reg_set): Remove. > (print_allocno_conflicts): Use global print_hard_reg_set(). > * sel-sched-dump.cc (print_hard_reg_set): Remove. > (dump_hard_reg_set): Use global print_hard_reg_set(). > * sel-sched-dump.h (dump_hard_reg_set): Mark as DEBUG_FUNCTION. > OK for me.  Thank you for consolidation of the print code, Maxim.