From: Richard Henderson <richard.henderson@linaro.org>
To: Matthew Malcomson <matthew.malcomson@arm.com>,
rth7680@gmail.com, gcc-patches@gcc.gnu.org
Cc: ramana.radhakrishnan@arm.com, agraf@suse.de, matz@suse.de
Subject: Re: [PATCH, AArch64 10/11] aarch64: Implement TImode compare-and-swap
Date: Thu, 27 Sep 2018 16:39:00 -0000 [thread overview]
Message-ID: <7f3cb69b-30d2-59b5-ead7-4933239e20fa@linaro.org> (raw)
In-Reply-To: <3460dd10-4d9a-1def-3f9b-5f7a1afe5906@arm.com>
On 9/27/18 6:04 AM, Matthew Malcomson wrote:
> Hi Richard,
>
>
> On 26/09/18 06:03, rth7680@gmail.com wrote:
>> From: Richard Henderson <richard.henderson@linaro.org>
>>
>> This pattern will only be used with the __sync functions, because
>> we do not yet have a bare TImode atomic load.
>>
>>
> I don't have any comment on the overall aim of the patch series, but in
> this particular
> patch it looks like you doesn't ensure the register pairs for casp are
> even-odd.
>
> This is the restriction in the Arm Arm decode for casp variants as
> Â if Rs<0> == '1' then UnallocatedEncoding();
> Â if Rt<0> == '1' then UnallocatedEncoding();
Oops. I missed this bit when reading the docs. Thanks.
I'll incorporate your even register class patch into the next round.
r~
next prev parent reply other threads:[~2018-09-27 16:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 5:04 [PATCH, AArch64 00/11] LSE atomics out-of-line rth7680
2018-09-26 5:04 ` [PATCH, AArch64 04/11] aarch64: Improve atomic-op lse generation rth7680
2018-09-26 5:04 ` [PATCH, AArch64 09/11] aarch64: Implement -matomic-ool rth7680
2018-09-26 5:04 ` [PATCH, AArch64 06/11] Add visibility to libfunc constructors rth7680
2018-09-26 5:04 ` [PATCH, AArch64 11/11] Enable -matomic-ool by default rth7680
2018-09-26 5:04 ` [PATCH, AArch64 03/11] aarch64: Improve swp generation rth7680
2018-09-26 5:04 ` [PATCH, AArch64 01/11] aarch64: Simplify LSE cas generation rth7680
2018-09-26 5:04 ` [PATCH, AArch64 07/11] Link static libgcc after shared libgcc for -shared-libgcc rth7680
2018-09-26 16:55 ` Joseph Myers
2018-09-26 16:57 ` Richard Henderson
2018-09-26 5:04 ` [PATCH, AArch64 05/11] aarch64: Emit LSE st<op> instructions rth7680
2018-09-26 5:04 ` [PATCH, AArch64 10/11] aarch64: Implement TImode compare-and-swap rth7680
2018-09-27 13:08 ` Matthew Malcomson
[not found] ` <3460dd10-4d9a-1def-3f9b-5f7a1afe5906@arm.com>
2018-09-27 16:39 ` Richard Henderson [this message]
2018-09-27 17:07 ` Matthew Malcomson
2018-10-01 13:51 ` Matthew Malcomson
2018-09-26 5:04 ` [PATCH, AArch64 08/11] aarch64: Add out-of-line functions for LSE atomics rth7680
2018-09-26 9:01 ` Florian Weimer
2018-09-26 14:33 ` Richard Henderson
2018-09-26 14:36 ` Florian Weimer
2018-09-26 14:37 ` Richard Henderson
2018-09-28 16:29 ` Ramana Radhakrishnan
2018-09-26 7:40 ` [PATCH, AArch64 02/11] aarch64: Improve cas generation rth7680
2018-09-26 9:22 ` [PATCH, AArch64 00/11] LSE atomics out-of-line Florian Weimer
2018-09-26 13:05 ` Michael Matz
2018-09-27 13:08 ` Ramana Radhakrishnan
2018-09-27 15:19 ` Alexander Graf
2018-09-27 16:51 ` Richard Henderson
2018-09-28 8:48 ` Ramana Radhakrishnan
2019-02-04 11:14 ` __libc_single_threaded variable for optimizing std::shared_ptr (was: [PATCH, AArch64 00/11] LSE atomics out-of-line) Florian Weimer
2019-02-04 12:15 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f3cb69b-30d2-59b5-ead7-4933239e20fa@linaro.org \
--to=richard.henderson@linaro.org \
--cc=agraf@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=matthew.malcomson@arm.com \
--cc=matz@suse.de \
--cc=ramana.radhakrishnan@arm.com \
--cc=rth7680@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).