From: Thomas Koenig <tkoenig@netcologne.de>
To: sgk@troutmask.apl.washington.edu, jakub@redhat.com
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, fortran] PR 84487
Date: Sun, 29 Sep 2019 22:20:00 -0000 [thread overview]
Message-ID: <7f657847-2b38-219e-5623-9a0cc3ad73d9@netcologne.de> (raw)
In-Reply-To: <20190928165318.GB15489@troutmask.apl.washington.edu>
Hi,
Jakub, do you have any comments? After Seve's OK I plan to commit in a
couple of days unless I read anything to the contrary.
Regards
Thomas
>> this patch makes sure that the __def_init variables, which have been
>> generated for normal allocatable arrays for quite some time, do not fill
>> up huge amounts of space in the object files with zeros. This is done by
>> not marking them read-only, which means that they are put into the BSS.
>>
>> Setting DECL_ARTIFICIAL on the __def_init variable makes sure it
>> is handled as predetermined shared in gfc_omp_predetermined_sharing .
>>
>> This is not an optimum solution. As the xfail shows, we are now missing
>> out on an optimization (as seen by the xfail that is now needed), and
>> having large all-zero variables seems wrong. However, this patch solves
>> the most urgent problem in this respect.
>>
>> This is an 8/9/10 regression, so I would like to commit this to
>> all of these branches (waiting before gcc 9 reopens, of course).
>>
>> I wold then close the PR and open an enchancement PR for the xfail
>> and the design improvement.
>>
>> Test case... I'm not sure what to test for.
>>
>> Regression-tested. OK for all affected branches?
>>
>
> Your approach seems reasonable to me. You may want to
> ping Jakub or Tobias as this affects openmp.
>
prev parent reply other threads:[~2019-09-29 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 20:24 Thomas Koenig
2019-09-28 16:53 ` Steve Kargl
2019-09-29 22:20 ` Thomas Koenig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f657847-2b38-219e-5623-9a0cc3ad73d9@netcologne.de \
--to=tkoenig@netcologne.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=sgk@troutmask.apl.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).