From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 7588B397280C for ; Sun, 20 Sep 2020 23:28:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7588B397280C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-304-mdPVW6KEPra135Nm95A-CQ-1; Sun, 20 Sep 2020 19:28:00 -0400 X-MC-Unique: mdPVW6KEPra135Nm95A-CQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 110271074644; Sun, 20 Sep 2020 23:27:59 +0000 (UTC) Received: from ovpn-114-91.phx2.redhat.com (ovpn-114-91.phx2.redhat.com [10.3.114.91]) by smtp.corp.redhat.com (Postfix) with ESMTP id 36CA373679; Sun, 20 Sep 2020 23:27:58 +0000 (UTC) Message-ID: <7f8263f98394a2e8916a95961507164895ecc3c8.camel@redhat.com> Subject: Re: New modref/ipa_modref optimization passes From: David Malcolm To: Jan Hubicka Cc: David =?UTF-8?Q?=C4=8Cepel=C3=ADk?= , gcc-patches@gcc.gnu.org Date: Sun, 20 Sep 2020 19:27:57 -0400 In-Reply-To: <20200920173043.GD6758@kam.mff.cuni.cz> References: <157394261677.27454.2367573047582814412@a285.localdomain> <20200919223255.GA69342@kam.mff.cuni.cz> <20200920173043.GD6758@kam.mff.cuni.cz> User-Agent: Evolution 3.32.5 (3.32.5-1.fc30) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Sep 2020 23:28:04 -0000 On Sun, 2020-09-20 at 19:30 +0200, Jan Hubicka wrote: > > [...] > > Should new C++ source files have a .cc suffix, rather than .c? > > > > [...] > > > > > + $(srcdir)/ipa-modref.h $(srcdir)/ipa-modref.c \ > > > > ...which would affect this ^^^^^^^^^^^^^ > > I was wondering about that and decided to stay with .c since it is > what > other ipa passes use. I can rename the files. Given that they're in the source tree now, maybe better to wait until some mass renaming in the future? > We have some sources with > .c extension and others with .cc while they are now all C++. Is there > some plan to clean it up? I think we've been avoiding it, partly out of a concern of making backports harder, and also because someone has to do the work. That said, it's yet another unfinished transition, and is technical debt for the project. It's confusing to newcomers. It's been bugging me for a while, so I might take a look at doing it in this cycle. Dave