public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] RISC-V Add Types to Un-Typed Thead Instructions:
Date: Sun, 10 Sep 2023 09:37:12 -0600	[thread overview]
Message-ID: <7fa41b97-dcf3-4a4c-bd86-e2f4de691f5a@gmail.com> (raw)
In-Reply-To: <20230831173637.583424-1-ewlu@rivosinc.com>



On 8/31/23 11:36, Edwin Lu wrote:
> Related Discussion:
> https://inbox.sourceware.org/gcc-patches/12fb5088-3f28-0a69-de1e-f387371a5eb2@gmail.com/
> 
> This patch updates the THEAD instructions to ensure that no insn is left
> without a type attribute.
> 
> Tested for regressions using rv32/64 multilib for linux/newlib.
> 
> gcc/Changelog:
> 
> 	* config/riscv/thead.md: Update types
OK.  THe first could arguably be "multi", but both instructions it 
generates appear to be move/conversions, so "fmove" is reasonable as well.

Ok for the trunk.  And I think that's should allow us to turn on the 
assertion, right?

jeff

  reply	other threads:[~2023-09-10 15:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-31 17:36 Edwin Lu
2023-09-10 15:37 ` Jeff Law [this message]
2023-09-11 17:20   ` Edwin Lu
2023-09-11 17:20     ` Edwin Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7fa41b97-dcf3-4a4c-bd86-e2f4de691f5a@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).