From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 139FE3858415 for ; Sun, 10 Sep 2023 15:37:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 139FE3858415 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-573ccec985dso2710523a12.2 for ; Sun, 10 Sep 2023 08:37:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694360234; x=1694965034; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mAb5rRauuHQ/NhZ3tTXyTBFjek0U3guk/XKWSH6GMjk=; b=UycIWdJuq40M67x8MNLuj5zYsLmYfcOdtwtjNUQomTl+LdjNoWPlOcar/GxYyJrf4z fpveK3NoupvweZL29tEjizeOQaNLA/8qLsSUQTruVOXJKR3z3EfAYfGeBIUM844mmz8E K0YWk8OfBfrkLu5Xhe3+OGd23ubqBggXcKy+C+dDbc+68Rmdom4+ngb7J+LFu9is6jbg XocVbHrYfm8PL5dfctpY8ZpWqaUasSDeGykx9J0hmjtC1G6EuOLRmFua/0rJDOmcB6QO YEd1ohtm95ObywDtYODKgBZt2IgOYYzl+0flpUww7CNCisY70n0BJVS3YVKoKa6CwTAY GfFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694360234; x=1694965034; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mAb5rRauuHQ/NhZ3tTXyTBFjek0U3guk/XKWSH6GMjk=; b=jCA8BZH7chTQWvtSjX5xww7lHb1qMq8CTJwkRHC/5MTsQjUnd9ICfWm3SdqBRZIrNH qROZLVw5z5LuOwWMWkfpcE3GBiieopTeINiIK7VNpkVnd2I9WiXbM9Yz7fsDXUTZDiRI +j6Lmo5k9esRsyTykqkRyCN/8P0zjhvBTXW1akDjKEhKzZukOetOMFzg9jFgGRirID8H YHbrX/mOlLSCkMEbkQqw0mFqhC2q9oDFHPAsFuZ+o7eP2j+g9KrfHtfXvCcUhBy8R7XP jhN/qHg8vwt+B7XaHfsyHPyJo+FAWv8ZHDqttUr64QwHcDyXV2AQxObYQDlPfM5Cs2Hm 2BvQ== X-Gm-Message-State: AOJu0YzZUXetxVWLy2E/IC5RLuo9Of5qd3LHzK0IHJrczQeu3ZWZUrKT r3scSLlV4CSzaBkOjKsf2VUiXJw848spNA== X-Google-Smtp-Source: AGHT+IEvw6caJ1wHPhk+x04Cplg+X77l8ivwG5zYZ86ruuCA3Izgz86uUlMQxr2Ez+8AgDSHYnWHag== X-Received: by 2002:a17:90b:896:b0:268:1068:4464 with SMTP id bj22-20020a17090b089600b0026810684464mr6721789pjb.30.1694360234381; Sun, 10 Sep 2023 08:37:14 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id c14-20020a17090ab28e00b0026f3e396882sm5884831pjr.45.2023.09.10.08.37.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Sep 2023 08:37:13 -0700 (PDT) Message-ID: <7fa41b97-dcf3-4a4c-bd86-e2f4de691f5a@gmail.com> Date: Sun, 10 Sep 2023 09:37:12 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RISC-V Add Types to Un-Typed Thead Instructions: Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <20230831173637.583424-1-ewlu@rivosinc.com> From: Jeff Law In-Reply-To: <20230831173637.583424-1-ewlu@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/31/23 11:36, Edwin Lu wrote: > Related Discussion: > https://inbox.sourceware.org/gcc-patches/12fb5088-3f28-0a69-de1e-f387371a5eb2@gmail.com/ > > This patch updates the THEAD instructions to ensure that no insn is left > without a type attribute. > > Tested for regressions using rv32/64 multilib for linux/newlib. > > gcc/Changelog: > > * config/riscv/thead.md: Update types OK. THe first could arguably be "multi", but both instructions it generates appear to be move/conversions, so "fmove" is reasonable as well. Ok for the trunk. And I think that's should allow us to turn on the assertion, right? jeff