public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Robin Dapp <rdapp.gcc@gmail.com>
To: Vineet Gupta <vineetg@rivosinc.com>, gcc-patches@gcc.gnu.org
Cc: rdapp.gcc@gmail.com, gnu-toolchain@rivosinc.com,
	Jeff Law <jeffreyalaw@gmail.com>
Subject: Re: [RFC] RISC-V: elide sign extend when expanding cmp_and_jump
Date: Wed, 25 Oct 2023 09:12:33 +0200	[thread overview]
Message-ID: <7fe582bc-d259-4d2a-bedf-4e1a334d7fc3@gmail.com> (raw)
In-Reply-To: <20231025050155.627837-1-vineetg@rivosinc.com>

Hi Vineet,

I was thinking of two things while skimming the code:

 - Couldn't we do this in the expanders directly?  Or is the
   subreg-promoted info gone until we reach that?

 - Should some common-code part be more suited to handle that?
   We already elide redundant sign-zero extensions for other
   reasons.  Maybe we could add subreg promoted handling there?

Regards
 Robin


  reply	other threads:[~2023-10-25  7:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-25  5:01 Vineet Gupta
2023-10-25  7:12 ` Robin Dapp [this message]
2023-10-25 13:32   ` Jeff Law
2023-10-25 13:47     ` Robin Dapp
2023-10-25 13:52       ` Jeff Law
2023-10-25 16:37         ` Vineet Gupta
2023-10-25 16:25   ` Vineet Gupta
2023-10-25 16:30     ` Jeff Law
2023-10-25 16:31       ` Vineet Gupta
2023-10-25 23:28 ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7fe582bc-d259-4d2a-bedf-4e1a334d7fc3@gmail.com \
    --to=rdapp.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gnu-toolchain@rivosinc.com \
    --cc=jeffreyalaw@gmail.com \
    --cc=vineetg@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).