Re: [PATCH] c++: Suppress error when cv-qualified reference is introduced by typedef [PR101783]

[Jason Merrill <jason@redhat.com>]

On 9/30/21 14:24, nick huang wrote:
>>> You may need to run contrib/gcc-git-customization.sh to get the git
>>> gcc-verify command.
> I re-setup and can use git gcc-verify. Now I can see it rejects because I forgot to add a
> description of modified file. Now that it passes gcc-verify and I attach the changelog
> as attachment.
> 
> Thank you again for your patient explanation and help!

You're welcome, thanks for your patience as well!  Unfortunately, git 
gcc-verify still fails with this version:

> ERR: line should start with a tab: "    PR c++/101783"
> ERR: line should start with a tab: "    * tree.c (cp_build_qualified_type_real): Excluding typedef from error"
> ERR: line should start with a tab: "    PR c++/101783"
> ERR: line should start with a tab: "    * g++.dg/parse/pr101783.C: New test."

It might work better to attach the output of git format-patch.

Also, your commit subject line is too long, at 83 characters: It must be 
under 75 characters, and preferably closer to 50.  I might shorten it to

c++: cv-qualified ref introduced by typedef [PR101783]

>     * tree.c (cp_build_qualified_type_real): Excluding typedef from error

A change description in the ChangeLog should use present tense 
("Exclude"), have a period at the end, and line wrap at 75 characters 
like the rest of the commit message.  So,

	* tree.c (cp_build_qualified_type_real): Exclude typedef from
	error.

> +     ([dcl.type.decltype]),in which case the cv-qualifiers are ignored.        
> +  */                                                                           

We usually don't put */ on its own line.

Jason