From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id CA0FE3858422 for ; Fri, 1 Oct 2021 13:29:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CA0FE3858422 Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-253-Go-hF5ozPhujjev7kta3VQ-1; Fri, 01 Oct 2021 09:29:08 -0400 X-MC-Unique: Go-hF5ozPhujjev7kta3VQ-1 Received: by mail-qt1-f199.google.com with SMTP id o9-20020ac80249000000b002a0c9fd54d5so14773684qtg.4 for ; Fri, 01 Oct 2021 06:29:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=4pMx8T0JMZe4TXJHROGF+incV89VouIdF3XoLDQnmGI=; b=KhlAjTEzbvGVSFLmCi5Nvbm98WoxrzGn6zSydilGkNnBaygetkfru/5LJXU3kkdsxc QU5s0vczn4fucyKSemv2Wr4JvJnqyjLEN4mVwUf8VPF4dDvBSvoU1LHFrdVI5P6GHW9I kkhwhJ2IfQX1HnSD2fv6O6imaHsUgP3iiGXxYwzgYLLN9JZWWtfC/M8L4LN9R1sJ3tEO fGuirRZh0OrCppzmKyYI7KRiLWwYda0mdh1lvNQdnqTea4Jaa5v9zVPi/oUweN8de7sZ 1KDnEO6wYJVH/ugFkkPIiSkiin8Is81GtIBZ/qBQACMZBBKbzrMIOBG5vHKE1iJu8z1J EqdA== X-Gm-Message-State: AOAM531c7uyfEKaKz/Ru9VeSwg6PhVf/2CVbBaTyGRlfeUaYLwFtyLJM +IzKURNlf4jslzGzIe2gooNK41uRMX/K96pJZRi2D0NWu0QAX2uuWi6UAn6vPs54u93e8DlEqtD COWavEmebNw4xM89ong== X-Received: by 2002:ae9:dcc7:: with SMTP id q190mr9802462qkf.194.1633094947959; Fri, 01 Oct 2021 06:29:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEqgbKP1xSlQmcqS++DIyYWGZH+uMgY3PO50oCVU9jNL+ll1XCoBBJe8FThvs6PZWOOVlJtA== X-Received: by 2002:ae9:dcc7:: with SMTP id q190mr9802444qkf.194.1633094947671; Fri, 01 Oct 2021 06:29:07 -0700 (PDT) Received: from [192.168.1.149] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id s20sm2990327qkj.116.2021.10.01.06.29.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Oct 2021 06:29:06 -0700 (PDT) Message-ID: <7ff72053-60e7-3c9b-3737-458ec40f1f77@redhat.com> Date: Fri, 1 Oct 2021 09:29:05 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH] c++: Suppress error when cv-qualified reference is introduced by typedef [PR101783] To: nick huang , Gcc-patches References: <41fa824d-59ff-07d1-50f5-2aacd88abf7e@redhat.com> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Oct 2021 13:29:12 -0000 On 9/30/21 14:24, nick huang wrote: >>> You may need to run contrib/gcc-git-customization.sh to get the git >>> gcc-verify command. > I re-setup and can use git gcc-verify. Now I can see it rejects because I forgot to add a > description of modified file. Now that it passes gcc-verify and I attach the changelog > as attachment. > > Thank you again for your patient explanation and help! You're welcome, thanks for your patience as well! Unfortunately, git gcc-verify still fails with this version: > ERR: line should start with a tab: " PR c++/101783" > ERR: line should start with a tab: " * tree.c (cp_build_qualified_type_real): Excluding typedef from error" > ERR: line should start with a tab: " PR c++/101783" > ERR: line should start with a tab: " * g++.dg/parse/pr101783.C: New test." It might work better to attach the output of git format-patch. Also, your commit subject line is too long, at 83 characters: It must be under 75 characters, and preferably closer to 50. I might shorten it to c++: cv-qualified ref introduced by typedef [PR101783] > * tree.c (cp_build_qualified_type_real): Excluding typedef from error A change description in the ChangeLog should use present tense ("Exclude"), have a period at the end, and line wrap at 75 characters like the rest of the commit message. So, * tree.c (cp_build_qualified_type_real): Exclude typedef from error. > + ([dcl.type.decltype]),in which case the cv-qualifiers are ignored. > + */ We usually don't put */ on its own line. Jason