From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 0F1543858CDB for ; Wed, 20 Mar 2024 08:21:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F1543858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0F1543858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710922907; cv=none; b=uwNYMWLTmXW8pfTMjQOnbhbh34cFz/ZOvTrZqs/YWg74T+MtfA0kcatUKfYF0ItgzwbrICg8N+aLvOo2L2PiTXAHiCpDvqajSwibiJo5FpRzWn8yY2Vp46q1ILPhvHsbptA9H1R6Do73W71CsS+uRrH+m0vjCXsE1D+D6Tryn0Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710922907; c=relaxed/simple; bh=SYfrGxF/UhjCJAnklaPw5W3HJOzmE3o5I138VgSz1a4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=mUK7O3zO0zv+OtpKdOzhkLj1YQtdRHur6UhDgKsJdTKMJeBFAJt2zdp+KmujqnNRvDBBwmgKH0vid2+c3r+xpxDSJ8ngy9dhWr2dGaSmCuNnZtLii9AtdOghkHjOpMWi6lc7uW5ElHSJVlWzUkfTc+yIoO5QvwGhy8WWSmVEv9k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 559CA20AA2; Wed, 20 Mar 2024 08:21:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710922903; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=auVeHQdEVgxFGhHSI72HDt8+qPrG6ez45oY6KGFRC1Y=; b=yffTQd6FVHcbBY0T/5Wb/aSdmupudS8z0mdo0BBccIr18iArMH8tCWVkrtu2EA6nc231i8 Mo3D5n7zOQZBazxJXRXSmKBXSoGyzBBqP70wfKzA6/yXBmun3lnfxpmqgaCtDpyfVT7UhD zwIjaaFMnPFfKc7pI5x6Kq24/VAfX8E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710922903; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=auVeHQdEVgxFGhHSI72HDt8+qPrG6ez45oY6KGFRC1Y=; b=q3jjPx1Nt5/Su1FREs5MUiOmrVJs8V6mMlZP6OuWQRRd3qF/jqpRbEUPr5qBSnNY7aUwcW 4NOYBeZgYpMc41DA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710922903; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=auVeHQdEVgxFGhHSI72HDt8+qPrG6ez45oY6KGFRC1Y=; b=yffTQd6FVHcbBY0T/5Wb/aSdmupudS8z0mdo0BBccIr18iArMH8tCWVkrtu2EA6nc231i8 Mo3D5n7zOQZBazxJXRXSmKBXSoGyzBBqP70wfKzA6/yXBmun3lnfxpmqgaCtDpyfVT7UhD zwIjaaFMnPFfKc7pI5x6Kq24/VAfX8E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710922903; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=auVeHQdEVgxFGhHSI72HDt8+qPrG6ez45oY6KGFRC1Y=; b=q3jjPx1Nt5/Su1FREs5MUiOmrVJs8V6mMlZP6OuWQRRd3qF/jqpRbEUPr5qBSnNY7aUwcW 4NOYBeZgYpMc41DA== Date: Wed, 20 Mar 2024 09:21:43 +0100 (CET) From: Richard Biener To: Hao Liu OS cc: "GCC-patches@gcc.gnu.org" Subject: Re: [PATCH] testsuite: add the case to cover vectorization of A[(i+x)*stride] [PR114322] In-Reply-To: Message-ID: <7n6o2538-p829-p52r-so19-s196924o6r59@fhfr.qr> References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -4.04 X-Spamd-Result: default: False [-4.04 / 50.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.977]; RCPT_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-2.74)[98.87%] X-Spam-Level: Authentication-Results: smtp-out2.suse.de; none X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 20 Mar 2024, Hao Liu OS wrote: > Hi Richard, > > As mentioned in the comments of PR114322 (which has been fixed by PR114151 > r14-9540-ge0e9499a), this patch is to cover the case. > > Bootstrapped and regression tested on aarch64-linux-gnu, OK for trunk? > > gcc/testsuite/ChangeLog: > > PR tree-optimization/114322 > * gcc.dg/vect/pr114322.c: New testcase. > > diff --git a/gcc/testsuite/gcc.dg/vect/pr114322.c b/gcc/testsuite/gcc.dg/vect/pr114322.c > new file mode 100644 > index 00000000000..7c3a4ffe260 > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/vect/pr114322.c > @@ -0,0 +1,18 @@ > +/* PR tree-optimization/114322 */ > +/* { dg-do compile } */ > + > +int > +foo (short *A, int x, int stride) > +{ > + int sum = 0; > + > + if (stride > 1) > + { > + for (int i = 0; i < 1024; ++i) > + sum += A[(i + x) * stride]; > + } > + > + return sum; > +} > + > +/* { dg-final { scan-tree-dump "LOOP VECTORIZED" "vect" { target aarch64*-*-* } } } */ I don't like the target selector very much - if you make 'A' a 'int *', the strided access should be the important part, vect_int should match the requirements - the strided access should end up with VMAT_ELEMENTWISE at worst (possibly gather on aarch64?), and VMAT_ELEMENTWISE doesn't need any alignment. So - OK with using { target vect_int } instead. Richard.