From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 8D9EB3858D28; Mon, 19 Jun 2023 02:49:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D9EB3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35J2HXcK005809; Mon, 19 Jun 2023 02:49:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=pp1; bh=2DhHxPe/el8Xft7oJ1xo+wO1+XuhTrjA2hN4D2Vefa0=; b=OphLSJ097yUGwITdoQnKI//sHOziJTLpxaYIu8W4F2WRrTMdftO1sQ4fTgAm6SZ+SWn9 ESkVLjvstdQxyfj1Lbx9mDAIPAL+MUTCaH+QdDoG0AeMHmfLXDCxau+x9MVfiwM1+0EJ QgtsG/gB+hlz3QJ0eSLHjG/QkAEIQr6fbz1Ncddm10VLy09/cWPaEdQ0qC2sgL16MKvV 7kaNS8aKw1vn+Si7wWolbaAJJ4rsJkm1n+QRS5QGo1LzwYFKgFVAvhVPA2oG9LQQEdBA 1USYOA5Q9CN3JkVKpdG0kLxZqoasTLpjDnYLPcLmo4cDe2I56KwjzgMa0d9WJE+i1lQh Wg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rae3mrfbk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Jun 2023 02:49:27 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 35J2QnbF030937; Mon, 19 Jun 2023 02:49:27 GMT Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rae3mrfbd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Jun 2023 02:49:27 +0000 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35J00Wid016692; Mon, 19 Jun 2023 02:49:26 GMT Received: from smtprelay04.dal12v.mail.ibm.com ([9.208.130.102]) by ppma03wdc.us.ibm.com (PPS) with ESMTPS id 3r94f5rhhy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Jun 2023 02:49:26 +0000 Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35J2nPZI58851672 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Jun 2023 02:49:26 GMT Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E2BAC58057; Mon, 19 Jun 2023 02:49:25 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BBAB858058; Mon, 19 Jun 2023 02:49:25 +0000 (GMT) Received: from ltcden2-lp1.aus.stglabs.ibm.com (unknown [9.3.90.43]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTPS; Mon, 19 Jun 2023 02:49:25 +0000 (GMT) From: Jiufu Guo To: Richard Biener Cc: gcc-patches@gcc.gnu.org, segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, bergner@linux.ibm.com, richard.sandiford@arm.com, jeffreyalaw@gmail.com Subject: Re: [PATCH] Check SCALAR_INT_MODE_P in try_const_anchors References: <20230616081455.1697928-1-guojiufu@linux.ibm.com> Date: Mon, 19 Jun 2023 10:49:20 +0800 In-Reply-To: (Richard Biener's message of "Fri, 16 Jun 2023 08:46:00 +0000 (UTC)") Message-ID: <7nbkhc6ua7.fsf@ltcden2-lp1.aus.stglabs.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: lTCtvePr4x4YmT2gMj4vyHwIj8iPbyE7 X-Proofpoint-GUID: fHvXeRD52APovaV64VDjr7AcAErP_lHA X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-18_16,2023-06-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxscore=0 adultscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 priorityscore=1501 mlxlogscore=999 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306190022 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Richard Biener writes: > On Fri, 16 Jun 2023, Jiufu Guo wrote: > >> Hi, >> >> The const_anchor in cse.cc supports integer constants only. >> There is a "gcc_assert (SCALAR_INT_MODE_P (mode))" in >> try_const_anchors. >> >> In the latest code, some non-integer modes are used with const int. >> For examples: >> "set (mem/c:BLK (xx) (const_int 0 [0])" occur in md files of >> rs6000, i386, arm, and pa. For this, the mode may be BLKmode. >> Pattern "(set (strict_low_part (xx)) (const_int xx))" could >> be generated in a few ports. For this, the mode may be VOIDmode. >> >> So, avoid mode other than SCALAR_INT_MODE in try_const_anchors >> would be needed. >> >> Some discussions in the previous thread: >> https://gcc.gnu.org/pipermail/gcc-patches/2023-June/621097.html >> >> Bootstrap ®test pass on ppc64{,le} and x86_64. >> Is this ok for trunk? > > OK. Thanks a lot! Committed via r14-1918-gc0bd79300e8fad. BR, Jeff (Jiufu Guo) > > Richard. > >> >> BR, >> Jeff (Jiufu Guo) >> >> gcc/ChangeLog: >> >> * cse.cc (try_const_anchors): Check SCALAR_INT_MODE. >> >> --- >> gcc/cse.cc | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/gcc/cse.cc b/gcc/cse.cc >> index 2bb63ac4105..ddb76fd281d 100644 >> --- a/gcc/cse.cc >> +++ b/gcc/cse.cc >> @@ -1312,11 +1312,10 @@ try_const_anchors (rtx src_const, machine_mode mode) >> rtx lower_exp = NULL_RTX, upper_exp = NULL_RTX; >> unsigned lower_old, upper_old; >> >> - /* CONST_INT is used for CC modes, but we should leave those alone. */ >> - if (GET_MODE_CLASS (mode) == MODE_CC) >> + /* CONST_INT may be in various modes, avoid non-scalar-int mode. */ >> + if (!SCALAR_INT_MODE_P (mode)) >> return NULL_RTX; >> >> - gcc_assert (SCALAR_INT_MODE_P (mode)); >> if (!compute_const_anchors (src_const, &lower_base, &lower_offs, >> &upper_base, &upper_offs)) >> return NULL_RTX; >>