From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 758AA3858D28; Wed, 26 Apr 2023 02:54:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 758AA3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33Q2rttl003105; Wed, 26 Apr 2023 02:54:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=pp1; bh=sM1bo91qHBS0XuTfiHT0aKTrO3dK/pkuUVJNOpZS5KE=; b=Yuw1s689z9SvyZq+dZgdMnrGcK2Gt00a97gWUPxUWTsS45xg1il7h7W6q2QEtgNhN+j9 BlfSCM57gFjVyT+jFJhOOXsS2pnCpjPgDlWIeb1Kfm0fb2o0/w6o9BqMPl112h2zMJ0Y WH55L6VhJVkZpXrYCphbRHpjLmKKd73hmJpjzPJO9/aPJh51hXR1sic/RAu3dqEY4noR 5PhiIqZo3BFtnD6Ikf44czLj42RKFkIq0q6KPf34fJ3JcAEYpWjyLL0vbGEt1vH0qUAD e6s9ru1YMqRluNVswbUQq681OhQcNh645mq+BUzLoAKeHmncTpRb/TLIXX/JhlyIsAak Yg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q6ue8g993-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Apr 2023 02:54:31 +0000 Received: from m0353723.ppops.net (m0353723.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 33Q2k0dL006803; Wed, 26 Apr 2023 02:54:25 GMT Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q6ue8g97t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Apr 2023 02:54:25 +0000 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33Q1Q14t010784; Wed, 26 Apr 2023 02:54:22 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([9.208.129.119]) by ppma04dal.us.ibm.com (PPS) with ESMTPS id 3q4778g4w6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Apr 2023 02:54:22 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33Q2sKeu17629522 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Apr 2023 02:54:20 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9A4D758055; Wed, 26 Apr 2023 02:54:20 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 51A0F5804B; Wed, 26 Apr 2023 02:54:20 +0000 (GMT) Received: from ltcden2-lp1.aus.stglabs.ibm.com (unknown [9.3.90.43]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTPS; Wed, 26 Apr 2023 02:54:20 +0000 (GMT) From: Jiufu Guo To: Jiufu Guo via Gcc-patches Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org Subject: Re: [PATCH] rs6000: mark tieable between INT and FLOAT References: <20230106122552.145679-1-guojiufu@linux.ibm.com> <7nttzfiz1q.fsf@ltcden2-lp1.aus.stglabs.ibm.com> Date: Wed, 26 Apr 2023 10:54:17 +0800 In-Reply-To: <7nttzfiz1q.fsf@ltcden2-lp1.aus.stglabs.ibm.com> (Jiufu Guo via Gcc-patches's message of "Tue, 21 Feb 2023 09:32:01 +0800") Message-ID: <7ncz3rmjza.fsf@ltcden2-lp1.aus.stglabs.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 4la5Lib6GpCFMdwpugHJc9e4wQh9TE2j X-Proofpoint-GUID: 7G4GPVZt4CZdBdGVLQax8fY8Tcc_uKWc X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-25_11,2023-04-25_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 mlxlogscore=999 impostorscore=0 mlxscore=0 bulkscore=0 spamscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304260021 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, I would ping this patch for stage1: https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609504.html BR, Jeff (Jiufu) Jiufu Guo via Gcc-patches writes: > Hi, > > Gently Ping: > https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609504.html > > BR, > Jeff (Jiufu) > > > Jiufu Guo writes: > >> Hi, >> >> During discussing/review patches in maillist, we find more modes are >> tieable, e.g. DI<->DF. With some discussion, I drafted this patch >> to mark more tieable modes. >> >> Bootstrap and regtest pass on ppc64{,le}. >> Is this ok for trunk? >> >> BR, >> Jeff (Jiufu) >> >> gcc/ChangeLog: >> >> * config/rs6000/rs6000.cc (rs6000_modes_tieable_p): Mark more tieable >> modes. >> >> gcc/testsuite/ChangeLog: >> >> * g++.target/powerpc/pr102024.C: Updated. >> >> --- >> gcc/config/rs6000/rs6000.cc | 9 +++++++++ >> gcc/testsuite/g++.target/powerpc/pr102024.C | 3 ++- >> 2 files changed, 11 insertions(+), 1 deletion(-) >> >> diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc >> index 6ac3adcec6b..3cb0186089e 100644 >> --- a/gcc/config/rs6000/rs6000.cc >> +++ b/gcc/config/rs6000/rs6000.cc >> @@ -1968,6 +1968,15 @@ rs6000_modes_tieable_p (machine_mode mode1, machine_mode mode2) >> if (ALTIVEC_OR_VSX_VECTOR_MODE (mode2)) >> return false; >> >> + /* SFmode format (IEEE DP) in register would not as required, >> + So SFmode is restrict here. */ >> + if (GET_MODE_CLASS (mode1) == MODE_FLOAT >> + && GET_MODE_CLASS (mode2) == MODE_INT) >> + return GET_MODE_SIZE (mode2) == UNITS_PER_FP_WORD && mode1 != SFmode; >> + if (GET_MODE_CLASS (mode1) == MODE_INT >> + && GET_MODE_CLASS (mode2) == MODE_FLOAT) >> + return GET_MODE_SIZE (mode1) == UNITS_PER_FP_WORD && mode2 != SFmode; >> + >> if (SCALAR_FLOAT_MODE_P (mode1)) >> return SCALAR_FLOAT_MODE_P (mode2); >> if (SCALAR_FLOAT_MODE_P (mode2)) >> diff --git a/gcc/testsuite/g++.target/powerpc/pr102024.C b/gcc/testsuite/g++.target/powerpc/pr102024.C >> index 769585052b5..27d2dc5e80b 100644 >> --- a/gcc/testsuite/g++.target/powerpc/pr102024.C >> +++ b/gcc/testsuite/g++.target/powerpc/pr102024.C >> @@ -5,7 +5,8 @@ >> // Test that a zero-width bit field in an otherwise homogeneous aggregate >> // generates a psabi warning and passes arguments in GPRs. >> >> -// { dg-final { scan-assembler-times {\mstd\M} 4 } } >> +// { dg-final { scan-assembler-times {\mmtvsrd\M} 4 { target has_arch_pwr8 } } } >> +// { dg-final { scan-assembler-times {\mstd\M} 4 { target { ! has_arch_pwr8 } } } } >> >> struct a_thing >> {