From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id B07043858D1E; Tue, 21 Feb 2023 01:32:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B07043858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31L0vrIU030177; Tue, 21 Feb 2023 01:32:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=pp1; bh=+ZDVgSRH5Cf6lpfNPOVotHIIG00VDqIlZUzEZ7nLLfY=; b=h1cspMzdpA13jiH30Xy5uv4D03F0qgs9v90hhk7SU/zfBmN9jMibxT+LmTCkPTUlnX/l 9c2/aKrFW88ifwh8rzSd/+yXuD40t4k6FU6ICUw8/Kat+15Y+ihL0TXg4ANQviRomh3d pTiwWf+CFhV13YyZsVv5uiawtmwu1dti4UUPhwbdAVEsHaOrgHWcCPeJ/MtMI5uKxu9Z He0eHw8lZNIi2PVhO3QDrVKDoWBEPdjuxhlVmrJJFXczjtHL02RiBgTb9L5e3w+3mAAv sqnYj5+lk3tePchiDKlp544/uqSd7X2LCoVgk7FjV07iKdDONHbHjkz4AK8luk/wr5sF Ew== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nvkvkrka8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Feb 2023 01:32:08 +0000 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 31L1Jaip009550; Tue, 21 Feb 2023 01:32:08 GMT Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nvkvkrk9w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Feb 2023 01:32:08 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 31L0bqvg011420; Tue, 21 Feb 2023 01:32:07 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([9.208.130.98]) by ppma01dal.us.ibm.com (PPS) with ESMTPS id 3ntpa7c49e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Feb 2023 01:32:07 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 31L1W5wn3670608 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Feb 2023 01:32:05 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 845955805B; Tue, 21 Feb 2023 01:32:05 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3C38658055; Tue, 21 Feb 2023 01:32:05 +0000 (GMT) Received: from ltcden2-lp1.aus.stglabs.ibm.com (unknown [9.3.90.43]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTPS; Tue, 21 Feb 2023 01:32:05 +0000 (GMT) From: Jiufu Guo To: gcc-patches@gcc.gnu.org Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org Subject: Re: [PATCH] rs6000: mark tieable between INT and FLOAT References: <20230106122552.145679-1-guojiufu@linux.ibm.com> Date: Tue, 21 Feb 2023 09:32:01 +0800 In-Reply-To: <20230106122552.145679-1-guojiufu@linux.ibm.com> (Jiufu Guo's message of "Fri, 6 Jan 2023 20:25:52 +0800") Message-ID: <7nttzfiz1q.fsf@ltcden2-lp1.aus.stglabs.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 4L4ivicdz-fQ3kccFNcHfYsQSQBXBTm0 X-Proofpoint-ORIG-GUID: c5F-0_SfK0-KX1sFqgBJQQ1mb0AKG6wa X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-20_19,2023-02-20_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 mlxscore=0 phishscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302210012 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Gently Ping: https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609504.html BR, Jeff (Jiufu) Jiufu Guo writes: > Hi, > > During discussing/review patches in maillist, we find more modes are > tieable, e.g. DI<->DF. With some discussion, I drafted this patch > to mark more tieable modes. > > Bootstrap and regtest pass on ppc64{,le}. > Is this ok for trunk? > > BR, > Jeff (Jiufu) > > gcc/ChangeLog: > > * config/rs6000/rs6000.cc (rs6000_modes_tieable_p): Mark more tieable > modes. > > gcc/testsuite/ChangeLog: > > * g++.target/powerpc/pr102024.C: Updated. > > --- > gcc/config/rs6000/rs6000.cc | 9 +++++++++ > gcc/testsuite/g++.target/powerpc/pr102024.C | 3 ++- > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc > index 6ac3adcec6b..3cb0186089e 100644 > --- a/gcc/config/rs6000/rs6000.cc > +++ b/gcc/config/rs6000/rs6000.cc > @@ -1968,6 +1968,15 @@ rs6000_modes_tieable_p (machine_mode mode1, machine_mode mode2) > if (ALTIVEC_OR_VSX_VECTOR_MODE (mode2)) > return false; > > + /* SFmode format (IEEE DP) in register would not as required, > + So SFmode is restrict here. */ > + if (GET_MODE_CLASS (mode1) == MODE_FLOAT > + && GET_MODE_CLASS (mode2) == MODE_INT) > + return GET_MODE_SIZE (mode2) == UNITS_PER_FP_WORD && mode1 != SFmode; > + if (GET_MODE_CLASS (mode1) == MODE_INT > + && GET_MODE_CLASS (mode2) == MODE_FLOAT) > + return GET_MODE_SIZE (mode1) == UNITS_PER_FP_WORD && mode2 != SFmode; > + > if (SCALAR_FLOAT_MODE_P (mode1)) > return SCALAR_FLOAT_MODE_P (mode2); > if (SCALAR_FLOAT_MODE_P (mode2)) > diff --git a/gcc/testsuite/g++.target/powerpc/pr102024.C b/gcc/testsuite/g++.target/powerpc/pr102024.C > index 769585052b5..27d2dc5e80b 100644 > --- a/gcc/testsuite/g++.target/powerpc/pr102024.C > +++ b/gcc/testsuite/g++.target/powerpc/pr102024.C > @@ -5,7 +5,8 @@ > // Test that a zero-width bit field in an otherwise homogeneous aggregate > // generates a psabi warning and passes arguments in GPRs. > > -// { dg-final { scan-assembler-times {\mstd\M} 4 } } > +// { dg-final { scan-assembler-times {\mmtvsrd\M} 4 { target has_arch_pwr8 } } } > +// { dg-final { scan-assembler-times {\mstd\M} 4 { target { ! has_arch_pwr8 } } } } > > struct a_thing > {