From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 45FB73858429 for ; Tue, 14 May 2024 12:29:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 45FB73858429 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 45FB73858429 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715689775; cv=none; b=h6LYlBzTFWfztwevrCJIjWCZgJgndWa2bofYovkobw6j+1bpUM5GQMk+W3ngDNcC3RwWGIeLE1I0NMs1XJHvSNwvW+hDv5t6cLZe+z2N40wWdM5Hh3v+qodxgQ2vgDzqdwRJ+AS94fUz1MmZt+/OIr7bDkJF3h236hnLXjSbIm8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715689775; c=relaxed/simple; bh=533QnOctdqaOsLPXmvlJvPkaRl+0Wq7siaRU76g6NbE=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=QgFhuMl1r4dCCIzIIkDI9iHgslCmyXuRJi2VVFwV65DM55tFCXt49pqNaMAm3P5RA5vWgq6QysNCYbDnrlziQ1Hyk3eisyQaeEhF1TQujQMsaHcooL725YB9AfvyFI1ss5OZ0mC/swBkpnHYPB1sGj3B67xrKGKbCvSIhJbsw4w= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from murzim.nue2.suse.org (unknown [10.168.4.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 294653E855; Tue, 14 May 2024 12:29:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715689772; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bkU5iNfmtjGLlTUpJnLyqjlRCEQk4jVt9kWgj9O9d8E=; b=lsrOdzmKC2fUS1CGghyTfuf3bCpNgdBjaOaLceeVE8lEjrGoIbooV6/kMtg87wtkuzChj0 KgJadLq60Bntzc3im8Zh7DkKLfimqdfb01kKF1e0dUDuM7Cx0aauO5qAqvnczsYddG7Qij teTw/AUbZkUecSwdZZWM/fk6iA0rZkc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715689772; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bkU5iNfmtjGLlTUpJnLyqjlRCEQk4jVt9kWgj9O9d8E=; b=dz9tD9bP+Rzcrvnvgl7TmG4LG5viLX2t5g7s+mZu7EGgLAQG0UNM8wDGxJdzMK6skmW9Gs 78Ngjt6pIZVt/NCg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715689772; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bkU5iNfmtjGLlTUpJnLyqjlRCEQk4jVt9kWgj9O9d8E=; b=lsrOdzmKC2fUS1CGghyTfuf3bCpNgdBjaOaLceeVE8lEjrGoIbooV6/kMtg87wtkuzChj0 KgJadLq60Bntzc3im8Zh7DkKLfimqdfb01kKF1e0dUDuM7Cx0aauO5qAqvnczsYddG7Qij teTw/AUbZkUecSwdZZWM/fk6iA0rZkc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715689772; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bkU5iNfmtjGLlTUpJnLyqjlRCEQk4jVt9kWgj9O9d8E=; b=dz9tD9bP+Rzcrvnvgl7TmG4LG5viLX2t5g7s+mZu7EGgLAQG0UNM8wDGxJdzMK6skmW9Gs 78Ngjt6pIZVt/NCg== Date: Tue, 14 May 2024 14:29:32 +0200 (CEST) From: Richard Biener To: Jan Hubicka cc: gcc-patches@gcc.gnu.org Subject: Re: Avoid TYPE_MAIN_VARIANT compares in TBAA In-Reply-To: Message-ID: <7s9p2ss8-p49q-or23-62po-76064nn7r1pn@fhfr.qr> References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -4.30 X-Spam-Level: X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_ZERO(0.00)[0]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email] X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 14 May 2024, Jan Hubicka wrote: > Hi, > while building more testcases for ipa-icf I noticed that there are two places > in aliasing code where we still compare TYPE_MAIN_VARIANT for pointer equality. > This is not good idea for LTO since type merging may not happen for example > when in one unit pointed to type is forward declared while in other it is fully > defined. We have same_type_for_tbaa for that. > > Bootstrapped/regtested x86_64-linux, OK? OK. Richard. > gcc/ChangeLog: > > * alias.cc (reference_alias_ptr_type_1): Use view_converted_memref_p. > * alias.h (view_converted_memref_p): Declare. > * tree-ssa-alias.cc (view_converted_memref_p): Export. > (ao_compare::compare_ao_refs): Use same_type_for_tbaa. > > diff --git a/gcc/alias.cc b/gcc/alias.cc > index 808e2095d9b..853e84d7439 100644 > --- a/gcc/alias.cc > +++ b/gcc/alias.cc > @@ -770,10 +770,7 @@ reference_alias_ptr_type_1 (tree *t) > /* If the innermost reference is a MEM_REF that has a > conversion embedded treat it like a VIEW_CONVERT_EXPR above, > using the memory access type for determining the alias-set. */ > - if (TREE_CODE (inner) == MEM_REF > - && (TYPE_MAIN_VARIANT (TREE_TYPE (inner)) > - != TYPE_MAIN_VARIANT > - (TREE_TYPE (TREE_TYPE (TREE_OPERAND (inner, 1)))))) > + if (view_converted_memref_p (inner)) > { > tree alias_ptrtype = TREE_TYPE (TREE_OPERAND (inner, 1)); > /* Unless we have the (aggregate) effective type of the access > diff --git a/gcc/alias.h b/gcc/alias.h > index f8d93e8b5f4..36095f0bf73 100644 > --- a/gcc/alias.h > +++ b/gcc/alias.h > @@ -41,6 +41,7 @@ bool alias_ptr_types_compatible_p (tree, tree); > int compare_base_decls (tree, tree); > bool refs_same_for_tbaa_p (tree, tree); > bool mems_same_for_tbaa_p (rtx, rtx); > +bool view_converted_memref_p (tree); > > /* This alias set can be used to force a memory to conflict with all > other memories, creating a barrier across which no memory reference > diff --git a/gcc/tree-ssa-alias.cc b/gcc/tree-ssa-alias.cc > index e7c1c1aa624..632cf78028b 100644 > --- a/gcc/tree-ssa-alias.cc > +++ b/gcc/tree-ssa-alias.cc > @@ -2044,7 +2044,7 @@ decl_refs_may_alias_p (tree ref1, tree base1, > which is done by ao_ref_base and thus one extra walk > of handled components is needed. */ > > -static bool > +bool > view_converted_memref_p (tree base) > { > if (TREE_CODE (base) != MEM_REF && TREE_CODE (base) != TARGET_MEM_REF) > @@ -4325,8 +4325,8 @@ ao_compare::compare_ao_refs (ao_ref *ref1, ao_ref *ref2, > else if ((end_struct_ref1 != NULL) != (end_struct_ref2 != NULL)) > return flags | ACCESS_PATH; > if (end_struct_ref1 > - && TYPE_MAIN_VARIANT (TREE_TYPE (end_struct_ref1)) > - != TYPE_MAIN_VARIANT (TREE_TYPE (end_struct_ref2))) > + && same_type_for_tbaa (TREE_TYPE (end_struct_ref1), > + TREE_TYPE (end_struct_ref2)) != 1) > return flags | ACCESS_PATH; > > /* Now compare all handled components of the access path. > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)