From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 142433858C2F for ; Thu, 15 Jun 2023 06:38:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 142433858C2F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35F6WBB2013000; Thu, 15 Jun 2023 06:38:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=CCpNgjrR4clhUsEdVoR59MH5c9Cv0F3zc1WK2alzhbI=; b=h3Q++8DVcduQzVsDSNJxHi4Zsl9vRU1yldCOmOtAkWv/4IqOpkq5ZGNeW5STRxK7Eqyo UZ8UcuS/RBij1+DuuQbraIRSyEmM1VZ3Jp9Eg76iEThmsduBidfZlr/bL2PG13Q2mOgn WguJjMoKO2/p2hcT9y5vxpUGucqLrPDWLjfnHkoBRWvjo9Lgr59qFHGPAzil0B7LxUP2 dfdD+7msuYQcRoTgoht6CHc8cMbBnqzBT5dotblU8Tu7T9oc9F6MBUdaTQUkXeduGCzz UjuHQJo7DJnoNq2gQ7+JjhjdgwICiMPu5FtPuPhUMCBPHT/GA6Ivzn03GdsBs0MS+7z/ sQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3r7wf9g4y4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Jun 2023 06:38:22 +0000 Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 35F6ZDPu025481; Thu, 15 Jun 2023 06:38:22 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3r7wf9g4xd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Jun 2023 06:38:22 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35F2U7d8021650; Thu, 15 Jun 2023 06:38:19 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma04ams.nl.ibm.com (PPS) with ESMTPS id 3r4gt53dxt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Jun 2023 06:38:19 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35F6cGLB20579022 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Jun 2023 06:38:16 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1A51320040; Thu, 15 Jun 2023 06:38:16 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C2BA52004E; Thu, 15 Jun 2023 06:38:13 +0000 (GMT) Received: from [9.177.83.19] (unknown [9.177.83.19]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 15 Jun 2023 06:38:13 +0000 (GMT) Message-ID: <804f6ee1-eb62-ea72-648e-1ac9036d0606@linux.ibm.com> Date: Thu, 15 Jun 2023 14:38:12 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: PING^3 [PATCH 0/9] rs6000: Rework rs6000_emit_vector_compare Content-Language: en-US To: gcc-patches@gcc.gnu.org Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, bergner@linux.ibm.com, meissner@linux.ibm.com References: <20221124091557.514727-1-linkw@linux.ibm.com> <59fbb646-c855-c4cd-10f9-40996f4e9720@linux.ibm.com> <73b2a139-0664-6dda-13c1-622d51745b30@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: <73b2a139-0664-6dda-13c1-622d51745b30@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: RqTQQNHQngHLpcXMgNapJrY_d5gEHqga X-Proofpoint-ORIG-GUID: sJoBjOU4sBt1Del9z889NBjtRmZDR6iV Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-15_03,2023-06-14_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 clxscore=1015 mlxlogscore=999 priorityscore=1501 malwarescore=0 impostorscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306150054 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Gentle ping this series: https://gcc.gnu.org/pipermail/gcc-patches/2022-November/607146.html BR, Kewen > >> >> on 2022/11/24 17:15, Kewen Lin wrote: >>> Hi, >>> >>> Following Segher's suggestion, this patch series is to rework >>> function rs6000_emit_vector_compare for vector float and int >>> in multiple steps, it's based on the previous attempts [1][2]. >>> As mentioned in [1], the need to rework this for float is to >>> make a centralized place for vector float comparison handlings >>> instead of supporting with swapping ops and reversing code etc. >>> dispersedly. It's also for a subsequent patch to handle >>> comparison operators with or without trapping math (PR105480). >>> With the handling on vector float reworked, we can further make >>> the handling on vector int simplified as shown. >>> >>> For Segher's concern about whether this rework causes any >>> assembly change, I constructed two testcases for vector float[3] >>> and int[4] respectively before, it showed the most are fine >>> excepting for the difference on LE and UNGT, it's demonstrated >>> as improvement since it uses GE instead of GT ior EQ. The >>> associated test case in patch 3/9 is a good example. >>> >>> Besides, w/ and w/o the whole patch series, I built the whole >>> SPEC2017 at options -O3 and -Ofast separately, checked the >>> differences on object assembly. The result showed that the >>> most are unchanged, except for: >>> >>> * at -O3, 521.wrf_r has 9 object files and 526.blender_r has >>> 9 object files with differences. >>> >>> * at -Ofast, 521.wrf_r has 12 object files, 526.blender_r has >>> one and 527.cam4_r has 4 object files with differences. >>> >>> By looking into these differences, all significant differences >>> are caused by the known improvement mentined above transforming >>> GT ior EQ to GE, which can also affect unrolling decision due >>> to insn count. Some other trivial differences are branch >>> target offset difference, nop difference for alignment, vsx >>> register number differences etc. >>> >>> I also evaluated the runtime performance for these changed >>> benchmarks, the result is neutral. >>> >>> These patches are bootstrapped and regress-tested >>> incrementally on powerpc64-linux-gnu P7 & P8, and >>> powerpc64le-linux-gnu P9 & P10. >>> >>> Is it ok for trunk? >>> >>> BR, >>> Kewen >>> ----- >>> [1] https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606375.html >>> [2] https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606376.html >>> [3] https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606504.html >>> [4] https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606506.html >>> >>> Kewen Lin (9): >>> rs6000: Rework vector float comparison in rs6000_emit_vector_compare - p1 >>> rs6000: Rework vector float comparison in rs6000_emit_vector_compare - p2 >>> rs6000: Rework vector float comparison in rs6000_emit_vector_compare - p3 >>> rs6000: Rework vector float comparison in rs6000_emit_vector_compare - p4 >>> rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p1 >>> rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p2 >>> rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p3 >>> rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p4 >>> rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p5 >>> >>> gcc/config/rs6000/rs6000.cc | 180 ++++++-------------- >>> gcc/testsuite/gcc.target/powerpc/vcond-fp.c | 25 +++ >>> 2 files changed, 74 insertions(+), 131 deletions(-) >>> create mode 100644 gcc/testsuite/gcc.target/powerpc/vcond-fp.c >>>