From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id 2F0453858023 for ; Tue, 23 Nov 2021 15:38:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2F0453858023 Received: by mail-pj1-x1029.google.com with SMTP id gt5so16922288pjb.1 for ; Tue, 23 Nov 2021 07:38:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=MzgNJDSg3ELXAxYFmHLImSYWjDWdSrBKwcSV9xaFTYo=; b=4vmLu04L8787R3lGMgtzO0dmEIixewdAqyKmgslAkrXV8tM8+kMCSwo5NQdy/7rH36 5V/JDAUr2cVHKFrrUR7y1LNF3k9/IepRVifyjy7jm054jh1JNz78B3XW4qns608bqovQ Ogqor5p/bkVRmkzHyZb9Tn/zjwrAGc5p4fqz4ORY02cEIOiGvTJCbPcdhIyqgImJh11y GLfxCsgH+vCQfJDTc72+R8Kt4hhW0qyKckb9ffXFafmDRsdm31Qf1kKE8BI17JpNsc9h u5ieV/MDULTYSZUO3Ijuol+zkmCVKf7q+3UaNt1iIHp+BwGzUh78UU0chk/ZANGV0CYD 8xJQ== X-Gm-Message-State: AOAM531H7NmwzRrB706eY2hi+oNpScgpqj0HaVOCeeYg+j2Km4w1v2Yz xuq+UBctJaTE8IlXHlHNbRNkxCav+NY= X-Google-Smtp-Source: ABdhPJzQfdrsgm0O2zQ+xnoSQVllaWnjIJzmXN9c13Qf+EwFKR5Jcy3FTGU8ELLMQK36o+HnUlExww== X-Received: by 2002:a17:902:9f98:b0:144:e777:f88e with SMTP id g24-20020a1709029f9800b00144e777f88emr7387982plq.31.1637681927237; Tue, 23 Nov 2021 07:38:47 -0800 (PST) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id t3sm6877226pfg.94.2021.11.23.07.38.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Nov 2021 07:38:46 -0800 (PST) Message-ID: <80552f43-bb51-4526-f06a-c4c4855d7073@gmail.com> Date: Tue, 23 Nov 2021 08:38:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] libcpp: Use [[likely]] conditionally Content-Language: en-US To: Christophe LYON , gcc-patches@gcc.gnu.org References: <20211122172235.19438-1-polacek@redhat.com> <01c229cd-8ce8-8057-c3b2-98260ee31ae4@gmail.com> <90c086c1-48f2-7df5-f5af-3bcd7e062b32@foss.st.com> From: Jeff Law In-Reply-To: <90c086c1-48f2-7df5-f5af-3bcd7e062b32@foss.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2021 15:38:50 -0000 On 11/23/2021 8:26 AM, Christophe LYON via Gcc-patches wrote: > Hi! > > On 23/11/2021 01:26, Jeff Law via Gcc-patches wrote: >> >> >> On 11/22/2021 10:22 AM, Marek Polacek via Gcc-patches wrote: >>> Let's hide [[likely]] behind a macro, to suppress warnings if the >>> compiler doesn't support it. >>> >>> Co-authored-by: Jonathan Wakely >>> >>> Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? >>> >>>     PR preprocessor/103355 >>> >>> libcpp/ChangeLog: >>> >>>     * lex.c: Use ATTR_LIKELY instead of [[likely]]. >>>     * system.h (ATTR_LIKELY): Define. >> OK >> jeff > > > This patch breaks the build when the host compiler is gcc-4.8.5, > because __has_cpp_attribute is not defined. Sigh.  I'd like to move to a more recent prereq if we could. > > Is this small patch OK with a proper ChangeLog? Yes.  Sorry about the breakage. jeff