public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: FX <fxcoudert@gmail.com>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] fortran/67802 -- Numeric constant character length must ...
Date: Thu, 01 Oct 2015 19:19:00 -0000	[thread overview]
Message-ID: <80957D24-B73A-4A24-AEBA-099B4DBAAE9F@gmail.com> (raw)
In-Reply-To: <20151001185454.GA7728@troutmask.apl.washington.edu>

> 2015-10-01  Steven G. Kargl  <kargl@gcc.gnu.org>
> 
> 	PR fortran/67802
> 	* decl.c (add_init_expr_to_sym): Numeric constant for character
> 	length must be an INTEGER.
> 
> 2015-10-01  Steven G. Kargl  <kargl@gcc.gnu.org>
> 
> 	PR fortran/67802
> 	* gfortran.dg/pr67802.f90: New test.

OK, but not with that error message. We currently don’t use the “shorthand” standard notation (like "scalar-int-expr”) in our error messages, and we should keep that consistent. So I would go with “character length should be of integer type” or something like that.

FX

  reply	other threads:[~2015-10-01 19:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-01 18:54 Steve Kargl
2015-10-01 19:19 ` FX [this message]
2015-10-01 19:45   ` Steve Kargl
2015-10-01 20:49     ` FX
2015-10-01 21:19 Dominique d'Humières
2015-10-01 23:25 ` Steve Kargl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80957D24-B73A-4A24-AEBA-099B4DBAAE9F@gmail.com \
    --to=fxcoudert@gmail.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=sgk@troutmask.apl.washington.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).