From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp002.apm-internet.net (smtp002.apm-internet.net [85.119.248.221]) by sourceware.org (Postfix) with ESMTPS id 828203858402 for ; Tue, 14 Sep 2021 18:19:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 828203858402 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sandoe.co.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=sandoe.co.uk Received: (qmail 92275 invoked from network); 14 Sep 2021 18:19:06 -0000 X-APM-Out-ID: 16316435469227 X-APM-Authkey: 257869/1(257869/1) 20 Received: from unknown (HELO ?192.168.1.214?) (81.138.1.83) by smtp002.apm-internet.net with SMTP; 14 Sep 2021 18:19:06 -0000 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: [PATCH] c++tools : Add a simple handler for ModuleCompiledRequest. From: Iain Sandoe In-Reply-To: Date: Tue, 14 Sep 2021 19:19:05 +0100 Cc: GCC Patches Content-Transfer-Encoding: quoted-printable Message-Id: <8097B156-F27E-4B6C-AC43-D8422B933BE4@sandoe.co.uk> References: <29C079CA-1093-4152-846A-98FA298B1899@sandoe.co.uk> To: Jason Merrill X-Mailer: Apple Mail (2.3445.104.21) X-Spam-Status: No, score=-15.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_COUK, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2021 18:19:08 -0000 > On 9 Sep 2021, at 17:15, Jason Merrill wrote: >=20 > On 8/18/21 3:13 PM, Iain Sandoe wrote: >> Hi, >> I have found it useful when working with modules stuff to have the = completed >> set of command/responses available (some people working with the = interfaces >> for more sophisticated tools are using them). This message is a = hand-shake >> telling the server that a CMI has been built, and for the simplistic = server >> implementation doesn=E2=80=99t need to do anything. >> This just replies with "OK=E2=80=9D. >> Tested on x86_64-darwin. >> OK for master? >> thanks >> Iain >> c++tools/ChangeLog: >> * resolver.cc (module_resolver::ModuleCompiledRequest): >> Add a simple handler. >> * resolver.h: Declare handler for ModuleCompiledRequest. >> --- >> c++tools/resolver.cc | 7 +++++++ >> c++tools/resolver.h | 4 ++++ >> 2 files changed, 11 insertions(+) >> diff --git a/c++tools/resolver.cc b/c++tools/resolver.cc >> index edd4624b121..f862161095d 100644 >> --- a/c++tools/resolver.cc >> +++ b/c++tools/resolver.cc >> @@ -307,3 +307,10 @@ module_resolver::IncludeTranslateRequest = (Cody::Server *s, Cody::Flags, >> return 0; >> } >=20 > Could use a comment here. OK with that added. this is what I pushed, thanks Iain [PATCH] c++tools : Add a simple handler for ModuleCompiledRequest. This just replies with "OK". c++tools/ChangeLog: * resolver.cc (module_resolver::ModuleCompiledRequest): Add a simple handler. * resolver.h: Declare handler for ModuleCompiledRequest. --- c++tools/resolver.cc | 11 +++++++++++ c++tools/resolver.h | 4 ++++ 2 files changed, 15 insertions(+) diff --git a/c++tools/resolver.cc b/c++tools/resolver.cc index edd4624b121..421fdaa55fe 100644 --- a/c++tools/resolver.cc +++ b/c++tools/resolver.cc @@ -307,3 +307,14 @@ module_resolver::IncludeTranslateRequest = (Cody::Server *s, Cody::Flags, return 0; } =20 +/* This handles a client notification to the server that a CMI has been + produced for a module. For this simplified server, we just accept + the transaction and respond with "OK". */ + +int +module_resolver::ModuleCompiledRequest (Cody::Server *s, Cody::Flags, + std::string &) +{ + s->OKResponse(); + return 0; +} diff --git a/c++tools/resolver.h b/c++tools/resolver.h index b2f4381b4fa..c1ce9564e7f 100644 --- a/c++tools/resolver.h +++ b/c++tools/resolver.h @@ -96,6 +96,10 @@ public: std::string &include) override; =20 + using parent::ModuleCompiledRequest; + virtual int ModuleCompiledRequest (Cody::Server *s, Cody::Flags = Flags, + std::string &Module) override; + private: using parent::GetCMISuffix; virtual char const *GetCMISuffix () override; --=20