From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 913123858D1E for ; Mon, 24 Apr 2023 15:23:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 913123858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33OFLAZL030986; Mon, 24 Apr 2023 15:23:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=kY7kWCbom+t7g0eK+OLElwEvq/wQ8/k/AmtXfHGOEh8=; b=qZ3LeSPmc27mhdZK7TtH5OXQZnePQ83u2bLMsJ/buAfqL7z0SXK/7AWlHJJFsoJ+aJL1 p3bkvG4oyxSXt1r4CoGa9IBLAfsaCp9V2Sv4MrQSJkhDSNHF4P7JA2aRAC+Texi05bAQ hCQCdInj/zTHMPKmDvK7dE2qvmgnaqLqDGUCkIe72JWC3/sSqbTzaG1Uxj4CSxrz719w 1OEP+CmjS5kVlFcmSlzWCAF6S/xj3AFSZ/Zl+NGGb2DTgVgPjR9ApmT84Ap/sIa9XW7t IHREFrFy5iXWAcK4IHDHikM9tl6MWJV4yjjfwziIZC7wu/6h0adcF+QfX2qsgDHyGpVm oQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q47d5bph8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 24 Apr 2023 15:23:12 +0000 Received: from m0353727.ppops.net (m0353727.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 33OFFrlx019513; Mon, 24 Apr 2023 15:23:11 GMT Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q47d5bpg4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 24 Apr 2023 15:23:11 +0000 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33ODjflx008544; Mon, 24 Apr 2023 15:23:09 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([9.208.130.101]) by ppma02dal.us.ibm.com (PPS) with ESMTPS id 3q4777xmrn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 24 Apr 2023 15:23:09 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33OFN74g64422216 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 24 Apr 2023 15:23:08 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B83105805F; Mon, 24 Apr 2023 15:23:07 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 18FFD58054; Mon, 24 Apr 2023 15:23:07 +0000 (GMT) Received: from [9.211.87.59] (unknown [9.211.87.59]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 24 Apr 2023 15:23:06 +0000 (GMT) Message-ID: <809ed95b-686c-e515-584b-a1a1d40e6f68@linux.ibm.com> Date: Mon, 24 Apr 2023 10:23:06 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 1/4] ree: Default ree pass for O2 and above for rs6000 target. Content-Language: en-US To: Segher Boessenkool , Ajit Agarwal Cc: gcc-patches , jeff Law , jakub Jelinek , Richard Biener References: <236aab6b-537f-7fb6-125c-220fb63f7521@linux.ibm.com> <20230419200011.GG19790@gate.crashing.org> From: Peter Bergner In-Reply-To: <20230419200011.GG19790@gate.crashing.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 5ToZCPxaG_AlXVusoH2r29SsKlobLZZc X-Proofpoint-GUID: 7OEH2vK_mHUG7xPVWFzqM28MAqHgpEPh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-24_09,2023-04-21_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 spamscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 clxscore=1015 mlxscore=0 malwarescore=0 mlxlogscore=687 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304240136 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/19/23 3:00 PM, Segher Boessenkool wrote: > On Wed, Apr 19, 2023 at 11:23:07PM +0530, Ajit Agarwal wrote: >> * common/config/rs6000/rs6000-common.cc: Add REE pass as a >> default rs6000 target pass for O2 and above. > > Why only for -O2? Only when optimising at all makes sense, people use > -O0 only when they want to skip as many optimisations as possible, maybe > because of compilation time concerns, maybe to avoid an ICE or other > bug. Isn't REE *always* a good thing, it never degrades code quality? > Or are there situations where it results in worse code? I think this is a case of following what the other architectures are doing. Namely, x86, aarch64, riscv, sparc, alpha and h8300 all enable -free at -O2 and above, not -O1. Not to say that is the best answer, but I think that is why we did the same. I agree I don't think -free can produce worse code which makes using it with -O1 and above an option. Maybe someone was worried about compile time??? Doesn't seem like an optimization like this would be too expensive though. Ajit, one thing that is missing from this specific patch is a change to gcc/doc/invoke.texi mentioning Power to the list of architectures that are enabling -free with the -O* options, which currently only mentions Alpha, AArch64 and x86. Being good community participants, it'd be good to add the missing riscv, sparc and h8300 when adding Power. Peter