From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by sourceware.org (Postfix) with ESMTPS id 76FB3385840F for ; Sat, 12 Nov 2022 19:42:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 76FB3385840F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-x236.google.com with SMTP id m204so7886283oib.6 for ; Sat, 12 Nov 2022 11:42:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v4/eYiBaJ7i+jSbUJFWLKcSIp9ihbgj2Az/sQPKLFyc=; b=ouxGLo1lOy0/+O2hS5bV+gb9TiWt2FKj9TGcXEbsBHFrD1CQusQqoFx8liYiCJ+N2H 99F3pIxw1jxZyftLjk4YqS1dEa5gay6+TCXXSVP7vt/UTfH9OR2lMLLtP1IQ3wYmfbg/ p4CKyGhPNGMUNnds/weLLDjnOjykGO586jFpiAaHcUcyDOQ/fPXHdWrnKH7hFXvg2Mk1 h6BqVthVg3zRDPQ3fEbIfZGe9hfUJ05Qgb5zxEucqvM7uG+DSs21x5U+boJOaKL2Esw0 ZVlBLuOSBDa4XOO+siVENNkCxb7a91z9F5ikxEyMkWudxtQ2hiPZdGNJ3DWQ2dcsQ3ii YwVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v4/eYiBaJ7i+jSbUJFWLKcSIp9ihbgj2Az/sQPKLFyc=; b=mES2wtF5YBCgvTcOTQf8PEDkcR9wgbxDo9tgibbG12ICS2HrPL1SfHBXMD+jUIfbRM rjWb69hvDufS0/IansjKsODpBtRk2A0w4mLoHWz/yWD33ppD9mHxU7SeMjD58k9cFFh4 JrcaJo49pfSjcv4Bu0sunA62l2817rKojCLatJ2TIcoS0Sesp4Xf9xhr11hJu/dp9mUd 1Wubbpilj/+/CgCizg06mWH9yjnYy9v6CTAyOJznyefm96dDZ1Jmopnd1Y7p3wNe+sFD NKeMYjOHeX4XEbHIHCvl0Er43wGzLZ5IhEa/sF7lMhH6s1zBsCNmMyoVMjc1S35saoQe XARw== X-Gm-Message-State: ANoB5pl88ebrneiNTnCIgZ3gyaWymSx/vW5Xic5HfrhOnac9lRrxl8pW vOyF6ZVb2PR+uQhShJVjmOc= X-Google-Smtp-Source: AA0mqf6IPgZ/Pho0RmT73aC/Z+BH3Uc/xv0yyIjGIxdoveCYwSjMgU8PgoAG706SoE55Rf4nzcy6Ng== X-Received: by 2002:a54:408b:0:b0:35a:4879:a65a with SMTP id i11-20020a54408b000000b0035a4879a65amr3057235oii.103.1668282164585; Sat, 12 Nov 2022 11:42:44 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id l5-20020a056830154500b00661a33883b8sm2338303otp.71.2022.11.12.11.42.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Nov 2022 11:42:43 -0800 (PST) Message-ID: <80a301f3-6b42-cbad-77b9-cc219eed54ce@gmail.com> Date: Sat, 12 Nov 2022 12:42:41 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] gcc: m68k: fix PR target/107645 Content-Language: en-US To: Max Filippov , gcc-patches@gcc.gnu.org Cc: Andreas Schwab References: <20221111194356.3922768-1-jcmvbkbc@gmail.com> From: Jeff Law In-Reply-To: <20221111194356.3922768-1-jcmvbkbc@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/11/22 12:43, Max Filippov wrote: > gcc/ > PR target/107645 > * config/m68k/predicates.md (symbolic_operand): Return false > when UNSPEC is under the CONST node. Isn't the underlying object still symbolic though, thus returning false seems wrong. insn 342 341 343 35 (set (reg:SI 97)         (mem/u:SI (plus:SI (reg:SI 13 %a5)                 (const:SI (unspec:SI [                             (symbol_ref:SI ("__gcov_kvp_dynamic_pool_index") [flags 0x40]  )                             (const_int 0 [0])                         ] 6))) [0  S4 A8])) "gcc/libgcc/libgcov.h":472:44 55 {*movsi_m68k2}      (expr_list:REG_EQUAL (symbol_ref:SI ("__gcov_kvp_dynamic_pool_index") [flags 0x40]  )         (nil))) ISTM that we'd need to strip the unspec and process its argument instead.  But maybe I'm missing something. jeff