From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id 836A13858404 for ; Wed, 31 Aug 2022 15:41:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 836A13858404 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x432.google.com with SMTP id l65so4433111pfl.8 for ; Wed, 31 Aug 2022 08:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=QTH9l0K1k0eNC5/QjBz9QYDbBLUhzbGG6zkY86Cy1NM=; b=TOPi/7QG5cN5yniZl3wosX45Yw4h8kukuB70VPdVAJtKJ06yka8DKN5yTK8R8nc8ZV A52HMoCUHIEkajvUsGVlzlLRSZerSIZkJ98P9TO3nqqvaavsFsv8P7esUfyWr+jfQval B+NhIom+AetQpNBomIMRph77ZdnmOIMUENGqi8sV1f79NoVcYlDmdIIDrv2NKN4jMlPK xGmeGIYFekrfq/Z1aehS15ZB9jZZ6PxkXJc9haSmASPOLqeQ4mHnl2WAV0QLzrzAiPgB DXJaZEZHpTOPmlqnIBVFKsTfcnu0dwQS4wPIJrzMUdnqt8LmbMsjOuizI+GguVuFVVOy XHyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=QTH9l0K1k0eNC5/QjBz9QYDbBLUhzbGG6zkY86Cy1NM=; b=kFKIOmCHT/0JynYURm7orv3Xw4yWLN2eUAtA/BYmaTlS5wLofrj8hXeB6XNLjivXRf EwbQ4eTHoVPpopoLLL3a3FXL8gRJqM6Bkof0+uxicB2RdY3jUn2r8iO56dtYb7sywg/O iQkMoV8Ff7bWXEIrTDlhVIB7MNEb8C3LI56kP24eKVAy+Mzqs2OFhDL/DVL7BPpB8ilv Qqv0pc8+bVxhhvoZ7w5Fw4RtUqUF+y5J7P2bwhm61Kbg8WQiYutpXUIGmagZyXRyGeqh jmdO9IG9xxxCtDv3vYIDt9P2/RoP7nnM1Kt15BbhAqj9O7tkvnZde5jHUoitoVb2wo1i UDkA== X-Gm-Message-State: ACgBeo3YbNzKrVgAN9VyO0O74i6Lb6OgSnwbK7bQvINRiTwFLsL1pyhh zXsUePI9SdXk1irDgWoVCfdaVPL2KtM= X-Google-Smtp-Source: AA6agR5IFkTJ6T3ZvA125UG+sWtKM3VBZw4orrV+9dTe2Lg5B/uz7mOlpjVw44Nj3CV+pNcNq/iAPg== X-Received: by 2002:a05:6a00:acc:b0:530:e79e:fc27 with SMTP id c12-20020a056a000acc00b00530e79efc27mr26975990pfl.61.1661960489919; Wed, 31 Aug 2022 08:41:29 -0700 (PDT) Received: from [172.31.0.204] (c-73-98-188-51.hsd1.ut.comcast.net. [73.98.188.51]) by smtp.gmail.com with ESMTPSA id l22-20020a17090af8d600b001f1acb6c3ebsm1449592pjd.34.2022.08.31.08.41.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 08:41:29 -0700 (PDT) Message-ID: <80a3a209-efd5-fa9d-8079-ca75c82c16e9@gmail.com> Date: Wed, 31 Aug 2022 09:41:28 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] nvptx: Silence unused variable warning Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <20220828110925.gxuejmyvilvqy66h@lug-owl.de> From: Jeff Law In-Reply-To: <20220828110925.gxuejmyvilvqy66h@lug-owl.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/28/2022 5:09 AM, Jan-Benedict Glaw wrote: > Hi! > > The nvptx backend defines ASM_OUTPUT_DEF along with > ASM_OUTPUT_DEF_FROM_DECLS. Much like the rs6000 coff target, nvptx > triggers an unused variable warning: > > /usr/lib/gcc-snapshot/bin/g++ -fno-PIE -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include -I../../gcc/gcc/../libcody -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace -o varasm.o -MT varasm.o -MMD -MP -MF ./.deps/varasm.TPo ../../gcc/gcc/varasm.cc > ../../gcc/gcc/varasm.cc: In function 'void output_constant_pool_contents(rtx_constant_pool*)': > ../../gcc/gcc/varasm.cc:4318:21: error: unused variable 'name' [-Werror=unused-variable] > 4318 | const char *name = XSTR (desc->sym, 0); > | ^~~~ > cc1plus: all warnings being treated as errors > make[1]: *** [Makefile:1145: varasm.o] Error 1 > > > Fixed the same way: > > diff --git a/gcc/config/nvptx/nvptx.h b/gcc/config/nvptx/nvptx.h > index ed72c253191..71297440566 100644 > --- a/gcc/config/nvptx/nvptx.h > +++ b/gcc/config/nvptx/nvptx.h > @@ -321,6 +321,9 @@ struct GTY(()) machine_function > #define ASM_OUTPUT_DEF(FILE,LABEL1,LABEL2) \ > do \ > { \ > + (void) (FILE); \ > + (void) (LABEL1); \ > + (void) (LABEL2); \ > gcc_unreachable (); \ > } \ > while (0) > > > Ok for HEAD? OK with a ChangeLog entry. jeff