public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Christophe Lyon <christophe.lyon@arm.com>
To: Torbjorn SVENSSON <torbjorn.svensson@foss.st.com>,
	gcc-patches@gcc.gnu.org
Cc: richard.sandiford@arm.com
Subject: Re: PING^1 [PATCH] testsuite: Do not prefix linker script with "-Wl,"
Date: Wed, 28 Sep 2022 16:08:00 +0200	[thread overview]
Message-ID: <80a54d59-9821-c3c9-f3ec-16b39829b7ae@arm.com> (raw)
In-Reply-To: <3b573461-a954-cbf4-a805-24a4acf5a931@foss.st.com>



On 9/28/22 11:18, Torbjorn SVENSSON via Gcc-patches wrote:
> Hi,
> 
> Ping: https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601831.html
> 
> Kind regards,
> Torbjörn
> 
> On 2022-09-19 18:57, Torbjörn SVENSSON wrote:
>> The linker script should not be prefixed with "-Wl," - it's not an
>> input file and does not interfere with the new dump output filename
>> strategy.
>>
>> gcc/testsuite/ChangeLog:
>>
I think you want to mention PR testsuite/95720 since it is related?

>>     * lib/gcc-defs.exp: Do not prefix linker script with "-Wl,".
>>
>> Signed-off-by: Torbjörn SVENSSON  <torbjorn.svensson@foss.st.com>
>> ---
>>   gcc/testsuite/lib/gcc-defs.exp | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gcc/testsuite/lib/gcc-defs.exp 
>> b/gcc/testsuite/lib/gcc-defs.exp
>> index 42ef1d85432..2102ed6f7a3 100644
>> --- a/gcc/testsuite/lib/gcc-defs.exp
>> +++ b/gcc/testsuite/lib/gcc-defs.exp
>> @@ -332,7 +332,7 @@ proc gcc_adjust_linker_flags_list { args } {
>>           continue
>>       } elseif { $skip != "" } then {
>>           set skip ""
>> -    } elseif { $opt == "-Xlinker" } then {
>> +    } elseif { $opt == "-Xlinker" || $opt == "-T" } then {
>>           set skip $opt
>>       } elseif { ![string match "-*" $opt] \
>>                  && [file isfile $opt] } {

  reply	other threads:[~2022-09-28 14:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-19 16:57 Torbjörn SVENSSON
2022-09-28  9:18 ` PING^1 " Torbjorn SVENSSON
2022-09-28 14:08   ` Christophe Lyon [this message]
2022-09-30 16:19   ` Richard Sandiford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80a54d59-9821-c3c9-f3ec-16b39829b7ae@arm.com \
    --to=christophe.lyon@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.sandiford@arm.com \
    --cc=torbjorn.svensson@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).