From: kugan <kugan.vivekanandarajah@linaro.org>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PR77719] Fix ICE in pp_string, at pretty-print.c:955
Date: Mon, 26 Sep 2016 06:44:00 -0000 [thread overview]
Message-ID: <80a87b62-c193-2309-332d-22b1949d3e91@linaro.org> (raw)
In-Reply-To: <cd8ddafe-fc17-d083-f730-6497fad6aa1e@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
On 25/09/16 04:50, kugan wrote:
> Hi,
>
> In make_new_ssa_for_def (tree-reassoc.c) we should use gimple_get_lhs to
> get lhs instead of gimple_assign_lhs as stmt can be builtins too.
> Attached patch fixes this.
>
> Testcase from PR (attached) seems to fail. I dont any fortran so I didnt
> try fixing it. Any help here is appreciate. The log is:
Here is a patch with the testcase based on the feedback from Joost
VandeVondele and Dominique d'Humieres. Bootstrapped and regression
tested on x86_64-linux-gnu with no new regressions.
Is this OK for trunk?
Thanks,
kugan
gcc/testsuite/ChangeLog:
2016-09-25 Kugan Vivekanandarajah <kuganv@linaro.org>
* gfortran.dg/pr77719.f90: New test.
gcc/ChangeLog:
2016-09-25 Kugan Vivekanandarajah <kuganv@linaro.org>
* tree-ssa-reassoc.c (make_new_ssa_for_def): Use gimple_get_lhs to get lhs
instead of gimple_assign_lhs as stmt can be builtins too.
[-- Attachment #2: pr77719.txt --]
[-- Type: text/plain, Size: 1427 bytes --]
diff --git a/gcc/testsuite/gfortran.dg/pr77719.f90 b/gcc/testsuite/gfortran.dg/pr77719.f90
index e69de29..974d70a 100644
--- a/gcc/testsuite/gfortran.dg/pr77719.f90
+++ b/gcc/testsuite/gfortran.dg/pr77719.f90
@@ -0,0 +1,26 @@
+! PR middle-end/77719
+! { dg-do compile }
+! { dg-options "-O3 -ffast-math" }
+
+SUBROUTINE urep_egr(erep,derep,surr)
+ INTEGER, PARAMETER :: dp=8
+ REAL(dp), INTENT(inout) :: erep, derep(3)
+ REAL(dp), INTENT(in) :: surr(2)
+ REAL(dp) :: de_z, rz
+ INTEGER :: isp,spdim,jsp,nsp
+ IF (n_urpoly > 0) THEN
+ IF (r < spxr(1,1)) THEN
+ ispg: DO isp = 1,spdim ! condition ca)
+ IF (isp /= spdim) THEN
+ nsp = 5 ! condition cb
+ DO jsp = 0,nsp
+ IF( jsp <= 3 ) THEN
+ ELSE
+ erep = erep + surr(jsp-3)*rz**(jsp)
+ ENDIF
+ END DO
+ END IF
+ END DO ispg
+ END IF
+ END IF
+END SUBROUTINE urep_egr
diff --git a/gcc/tree-ssa-reassoc.c b/gcc/tree-ssa-reassoc.c
index 8fc76e4..d94ff70 100644
--- a/gcc/tree-ssa-reassoc.c
+++ b/gcc/tree-ssa-reassoc.c
@@ -1158,7 +1158,7 @@ make_new_ssa_for_def (gimple *stmt)
use_operand_p use;
imm_use_iterator iter;
tree new_lhs;
- tree lhs = gimple_assign_lhs (stmt);
+ tree lhs = gimple_get_lhs (stmt);
new_lhs = make_ssa_name (TREE_TYPE (lhs));
gimple_set_lhs (stmt, new_lhs);
next prev parent reply other threads:[~2016-09-26 2:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 7:07 kugan
2016-09-26 6:44 ` kugan [this message]
2016-09-26 15:46 ` Jeff Law
2016-09-25 7:46 Dominique d'Humières
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80a87b62-c193-2309-332d-22b1949d3e91@linaro.org \
--to=kugan.vivekanandarajah@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).