From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 313A9385843E for ; Tue, 14 Dec 2021 15:07:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 313A9385843E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0CA2E212B5; Tue, 14 Dec 2021 15:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1639494476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v+islYs62zkJdkS5TMSB9ia2FKAIIaI9ZaBdC8hZO1c=; b=Dos+9eQpu4n4WyDt2Sy8i/fwKjsm4QmH9hiYd+4MJ6oey35P1c0kseRCh2cABlOsCJ3esk zJggUJ1jEh3VOho4slv2GE+p32cFUQdMmQ3SwTYtO549STR9mMXmA6hrGutKxU00K3iSj4 zSbBihg9IP5oKHaiJhNEacNUMjGEAzo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1639494476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v+islYs62zkJdkS5TMSB9ia2FKAIIaI9ZaBdC8hZO1c=; b=bhYtSdBDy5OdTS5yYzlRKN/ecAoJM/EHGz09GTQz6Rh5NfKZR5kKeobDljW+ZG9cA8eEAI 4QTnJwbTEQRwhhDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E731D13DF1; Tue, 14 Dec 2021 15:07:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 69ZbN0uzuGGVWwAAMHmgww (envelope-from ); Tue, 14 Dec 2021 15:07:55 +0000 Content-Type: multipart/mixed; boundary="------------8o0UtRTj3Lm4neEmDQl3CLXN" Message-ID: <80d628c2-ea0d-c542-b0bb-399d83b7292d@suse.cz> Date: Tue, 14 Dec 2021 16:07:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Subject: Re: [PATCH] i386: Fix emissing of __builtin_cpu_supports. To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org, Stefan Kneifel References: <20211214102828.GU2646553@tucnak> Content-Language: en-US In-Reply-To: <20211214102828.GU2646553@tucnak> X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Dec 2021 15:07:59 -0000 This is a multi-part message in MIME format. --------------8o0UtRTj3Lm4neEmDQl3CLXN Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/14/21 11:28, Jakub Jelinek wrote: > Wouldn't this be better done only if field_val has the msb set Yes, updated in the attached patch. > and keep the CONVERT_EXPR otherwise (why isn't it NOP_EXPR?)? Dunno, but I can prepare a separate patch (likely stage1 material, right)? Note that are other places that also use CONVERT_EXPR. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin --------------8o0UtRTj3Lm4neEmDQl3CLXN Content-Type: text/x-patch; charset=UTF-8; name="0001-i386-Fix-emissing-of-__builtin_cpu_supports.patch" Content-Disposition: attachment; filename="0001-i386-Fix-emissing-of-__builtin_cpu_supports.patch" Content-Transfer-Encoding: base64 RnJvbSAyMjc0NTBlOWYzYTUwNmZkZmNmZjY3YWE0NTEzNWZlMzFmM2Y5MWY2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gTGlza2EgPG1saXNrYUBzdXNlLmN6PgpE YXRlOiBNb24sIDEzIERlYyAyMDIxIDE1OjM0OjMwICswMTAwClN1YmplY3Q6IFtQQVRDSF0g aTM4NjogRml4IGVtaXNzaW5nIG9mIF9fYnVpbHRpbl9jcHVfc3VwcG9ydHMuCgoJUFIgdGFy Z2V0LzEwMzY2MQoKZ2NjL0NoYW5nZUxvZzoKCgkqIGNvbmZpZy9pMzg2L2kzODYtYnVpbHRp bnMuYyAoZm9sZF9idWlsdGluX2NwdSk6IENvbXBhcmUgdG8gMAoJYXMgQVBJIGV4cGVjdHMg dGhhdCBub24temVybyB2YWx1ZXMgYXJlIHJldHVybmVkIChkbyB0aGF0CglpdCBtYXNrID09 IDMxKS4KCUZvciAiYXZ4NTEydmJtaTIiIGFyZ3VtZW50LCB3ZSByZXR1cm4gbm93IDEgPDwg MzEsIHdoaWNoIGlzIGEKCW5lZ2F0aXZlIGludGVnZXIgdmFsdWUuCi0tLQogZ2NjL2NvbmZp Zy9pMzg2L2kzODYtYnVpbHRpbnMuYyB8IDYgKysrKystCiAxIGZpbGUgY2hhbmdlZCwgNSBp bnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZ2NjL2NvbmZpZy9p Mzg2L2kzODYtYnVpbHRpbnMuYyBiL2djYy9jb25maWcvaTM4Ni9pMzg2LWJ1aWx0aW5zLmMK aW5kZXggMGZiMTRiNTU3MTIuLmJjYTI0NGZjMDExIDEwMDY0NAotLS0gYS9nY2MvY29uZmln L2kzODYvaTM4Ni1idWlsdGlucy5jCisrKyBiL2djYy9jb25maWcvaTM4Ni9pMzg2LWJ1aWx0 aW5zLmMKQEAgLTIzNTMsNyArMjM1MywxMSBAQCBmb2xkX2J1aWx0aW5fY3B1ICh0cmVlIGZu ZGVjbCwgdHJlZSAqYXJncykKICAgICAgIC8qIFJldHVybiBfX2NwdV9tb2RlbC5fX2NwdV9m ZWF0dXJlc1swXSAmIGZpZWxkX3ZhbCAgKi8KICAgICAgIGZpbmFsID0gYnVpbGQyIChCSVRf QU5EX0VYUFIsIHVuc2lnbmVkX3R5cGVfbm9kZSwgYXJyYXlfZWx0LAogCQkgICAgICBidWls ZF9pbnRfY3N0dSAodW5zaWduZWRfdHlwZV9ub2RlLCBmaWVsZF92YWwpKTsKLSAgICAgIHJl dHVybiBidWlsZDEgKENPTlZFUlRfRVhQUiwgaW50ZWdlcl90eXBlX25vZGUsIGZpbmFsKTsK KyAgICAgIGlmIChpc2FfbmFtZXNfdGFibGVbaV0uZmVhdHVyZSA9PSAzMSkKKwlyZXR1cm4g YnVpbGQyIChORV9FWFBSLCBpbnRlZ2VyX3R5cGVfbm9kZSwgZmluYWwsCisJCSAgICAgICBi dWlsZF9pbnRfY3N0ICh1bnNpZ25lZF90eXBlX25vZGUsIDApKTsKKyAgICAgIGVsc2UKKwly ZXR1cm4gYnVpbGQxIChDT05WRVJUX0VYUFIsIGludGVnZXJfdHlwZV9ub2RlLCBmaW5hbCk7 CiAgICAgfQogICBnY2NfdW5yZWFjaGFibGUgKCk7CiB9Ci0tIAoyLjM0LjEKCg== --------------8o0UtRTj3Lm4neEmDQl3CLXN--