From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12355 invoked by alias); 24 Oct 2017 15:06:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12340 invoked by uid 89); 24 Oct 2017 15:06:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=Hx-spam-relays-external:209.85.216.196, H*RU:209.85.216.196 X-HELO: mail-qt0-f196.google.com Received: from mail-qt0-f196.google.com (HELO mail-qt0-f196.google.com) (209.85.216.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Oct 2017 15:06:54 +0000 Received: by mail-qt0-f196.google.com with SMTP id f8so30821842qta.5 for ; Tue, 24 Oct 2017 08:06:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ktm1dDaP2gCuWNrLV+wTZGA1PweKddnJIoB5E7qeBQ8=; b=cTf9dKYVPMESCApnpBLvIq7XhtvfccTVGXp+FzkJ6i4GD/B57MDp3tzstZ26E7Rwfe fxnLB2iqVuwy9m64vlPqZzdO1rJ8eXqcXmzgH1d7yyOHt4h9UremDpU3aX3ae/6auiNj vteUZj9mDCSZp5CxEw7CfvblW4+nyUivOvx+MMp0boHLQ6JPu39EOHScsRYm41dBguPv brbcoybgFBBNgZfoE3CqEyUU7hu3ZbkOu8CQPme7UpLx2a/e5JW2zy2LQtwAvXu+I2j2 +IR8fesQ2mOdpYqWLuBRXNtSFscYvxcnehOH8Webmr5z/g5eFW2e6nUss6beMT8VqM9n ujCw== X-Gm-Message-State: AMCzsaWSclNyQsMhTUl8srV+Lt12yLcVr2V1r6rsNgTRj3/7D2l9PF7/ o1ypxW6WYPELiR3glW/KwCAuuA== X-Google-Smtp-Source: ABhQp+RwXvzwln4oy46vRhylolTT4dhMDKj8vCvXOyEfX+sS9BBF3IQ75biahdHszmbwYvhIVZ6H5Q== X-Received: by 10.200.6.136 with SMTP id f8mr22416310qth.265.1508857612976; Tue, 24 Oct 2017 08:06:52 -0700 (PDT) Received: from [192.168.1.132] (209-6-90-240.s1774.c3-0.smr-ubr1.sbo-smr.ma.cable.rcncustomer.com. [209.6.90.240]) by smtp.gmail.com with ESMTPSA id g11sm327637qkb.58.2017.10.24.08.06.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Oct 2017 08:06:52 -0700 (PDT) Subject: Re: [PATCH] Improve -Ofast vectorization of std::sin etc. (PR libstdc++/81706) To: Jakub Jelinek Cc: "Joseph S. Myers" , Marek Polacek , Jonathan Wakely , gcc-patches List , libstdc++ References: <20170807090825.GK2123@tucnak> <20170807152742.GM2123@tucnak> <20170901111249.GD2323@tucnak> <20170912074920.GC1701@tucnak> <20170929123233.GK1701@tucnak> From: Jason Merrill Message-ID: <80f60fe4-f8f3-5da7-23bb-72d8604d838b@redhat.com> Date: Tue, 24 Oct 2017 15:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170929123233.GK1701@tucnak> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg01711.txt.bz2 On 09/29/2017 08:32 AM, Jakub Jelinek wrote: > + tree b = builtin_decl_explicit (DECL_FUNCTION_CODE (newdecl)); > + if (b) > + duplicate_one_attribute (&DECL_ATTRIBUTES (b), > + DECL_ATTRIBUTES (newdecl), > + "omp declare simd"); It occurs to me that we're likely to want to propagate other attributes to the builtin, too. In the testcase, nothrow and leaf also seem appropriate. Do we want a broader copy_attributes_to_builtin function, even if it only copies this omp attribute for now? Jason