From: Jeff Law <jeffreyalaw@gmail.com>
To: "Martin Liška" <mliska@suse.cz>,
"Richard Biener" <richard.guenther@gmail.com>,
"Alexandre Oliva" <aoliva@gcc.gnu.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Remove MAY_HAVE_DEBUG_MARKER_STMTS and MAY_HAVE_DEBUG_BIND_STMTS.
Date: Mon, 15 Nov 2021 19:21:11 -0700 [thread overview]
Message-ID: <80fe31b8-4a35-419b-203f-d48878dcc212@gmail.com> (raw)
In-Reply-To: <ccfb2971-554b-09e9-05a5-e4114adc005f@suse.cz>
On 11/12/2021 7:37 AM, Martin Liška wrote:
> @Alexandre: PING
>
> On 10/18/21 12:05, Richard Biener wrote:
>> On Mon, Oct 18, 2021 at 10:54 AM Martin Liška <mliska@suse.cz> wrote:
>>>
>>> The macros correspond 1:1 to an option flags and make it harder
>>> to find all usages of the flags.
>>>
>>> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>>>
>>> Ready to be installed?
>>
>> Hmm, they were introduced on purpose - since you leave around
>> MAY_HAVE_DEBUG_STMTS they conceptually make the code
>> easier to understand.
>>
>> So I'm not sure if we want this change. CCed Alex so maybe he
>> can weight in.
I'd give it another 48hrs, then go ahead and commit. My recollection is
those were in place to allow the bulk of the work to go in independent
of the switches that activated the SFN debugging bits.
Jeff
next prev parent reply other threads:[~2021-11-16 2:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 8:54 Martin Liška
2021-10-18 10:05 ` Richard Biener
2021-11-12 14:37 ` Martin Liška
2021-11-16 2:21 ` Jeff Law [this message]
2021-11-19 8:59 ` Alexandre Oliva
2021-11-19 9:38 ` Richard Biener
2021-11-19 9:44 ` Jakub Jelinek
2021-11-19 13:22 ` Martin Liška
2021-11-19 14:06 ` Richard Biener
2021-11-19 14:30 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80fe31b8-4a35-419b-203f-d48878dcc212@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=aoliva@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).