From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by sourceware.org (Postfix) with ESMTPS id 714E83858431; Tue, 16 Nov 2021 02:21:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 714E83858431 Received: by mail-pj1-x1032.google.com with SMTP id o6-20020a17090a0a0600b001a64b9a11aeso1470344pjo.3; Mon, 15 Nov 2021 18:21:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=fI2nyoUolwOPR7keLROA5OaoOjaL8TSAEdbFyM855vE=; b=nqfa22DNOc7hrq8G65812+uHenGmywN6un8jbtoD9L+vTajpud+oNeuQS9FClHiCwF +xJ6yMS+8iMN21AhbqVRNkctxyRZUCIgJxcXEwSdIDi8HaPilpNayKzkymiMQYX/kGUV 56KhB8G2T7sfOygSri5THLNZ77yeMINJz+gdQj8zGu0GoaIkgmJV9lpttEv+DnRRk6OT AB7+fu2abqedwuVAGAWMv8gThNGrCbffOV6ZhdhPgXLRnjG1pCNKp2EgKrofPgfH0BW8 aH+Jldqdxz2nA2yuIT/s902Y3CzeXRvKyb4yx1oIkGi2RYC+2fuXiY1547DHc8He/wRi iq2g== X-Gm-Message-State: AOAM531ZGc16yktc1+O0RgUD8rwIFfToWp4Cg67RdfSyEv2scZPiR5PB AshbrsNvYxsRB9DSdOkfgcU= X-Google-Smtp-Source: ABdhPJzKqnqqYi1he8WQvfhUeagL7fcv3sVmbXgfS0r189Pbu2a+9qdEnEnMQ50RRMG5lfzNHDv5og== X-Received: by 2002:a17:90b:30e:: with SMTP id ay14mr4236998pjb.60.1637029273486; Mon, 15 Nov 2021 18:21:13 -0800 (PST) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id b19sm17878907pfv.63.2021.11.15.18.21.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Nov 2021 18:21:13 -0800 (PST) Message-ID: <80fe31b8-4a35-419b-203f-d48878dcc212@gmail.com> Date: Mon, 15 Nov 2021 19:21:11 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] Remove MAY_HAVE_DEBUG_MARKER_STMTS and MAY_HAVE_DEBUG_BIND_STMTS. Content-Language: en-US To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , Richard Biener , Alexandre Oliva Cc: GCC Patches References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Nov 2021 02:21:15 -0000 On 11/12/2021 7:37 AM, Martin Liška wrote: > @Alexandre: PING > > On 10/18/21 12:05, Richard Biener wrote: >> On Mon, Oct 18, 2021 at 10:54 AM Martin Liška wrote: >>> >>> The macros correspond 1:1 to an option flags and make it harder >>> to find all usages of the flags. >>> >>> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >>> >>> Ready to be installed? >> >> Hmm, they were introduced on purpose - since you leave around >> MAY_HAVE_DEBUG_STMTS they conceptually make the code >> easier to understand. >> >> So I'm not sure if we want this change.  CCed Alex so maybe he >> can weight in. I'd give it another 48hrs, then go ahead and commit.  My recollection is those were in place to allow the bulk of the work to go in independent of the switches that activated the SFN debugging bits. Jeff