From: Matthias Kretz <m.kretz@gsi.de>
To: <gcc-patches@gcc.gnu.org>, <libstdc++@gcc.gnu.org>
Subject: [PATCH] libstdc++: Don't fail if math_errhandling is not defined
Date: Mon, 17 Jan 2022 11:21:41 +0100 [thread overview]
Message-ID: <8121446.T7Z3S40VBb@minbar> (raw)
[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]
Tested on x86_64-linux and powerpc64le-linux. This fixes the powerpc64le-linux
failure Jonathan reported. OK for trunk?
Older glibc does not define math_errhandling with -ffast-math, in which
case floating-point exceptions are not used.
Signed-off-by: Matthias Kretz <m.kretz@gsi.de>
libstdc++-v3/ChangeLog:
* include/experimental/bits/simd.h (__floating_point_flags): Do
not rely on the presence of the math_errhandling macro.
---
libstdc++-v3/include/experimental/bits/simd.h | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
--
──────────────────────────────────────────────────────────────────────────
Dr. Matthias Kretz https://mattkretz.github.io
GSI Helmholtz Centre for Heavy Ion Research https://gsi.de
stdₓ::simd
──────────────────────────────────────────────────────────────────────────
[-- Attachment #2: 0001-libstdc-Don-t-fail-if-math_errhandling-is-not-define.patch --]
[-- Type: text/x-patch, Size: 790 bytes --]
diff --git a/libstdc++-v3/include/experimental/bits/simd.h b/libstdc++-v3/include/experimental/bits/simd.h
index d837d0efb21..c991e3f223e 100644
--- a/libstdc++-v3/include/experimental/bits/simd.h
+++ b/libstdc++-v3/include/experimental/bits/simd.h
@@ -283,11 +283,20 @@ constexpr inline bool __have_power_vmx = __have_power_vsx;
namespace __detail
{
+ constexpr bool __handle_fpexcept =
+#ifdef math_errhandling
+ math_errhandling & MATH_ERREXCEPT;
+#elif defined __FAST_MATH__
+ false;
+#else
+ true;
+#endif
+
constexpr std::uint_least64_t
__floating_point_flags()
{
std::uint_least64_t __flags = 0;
- if constexpr (math_errhandling & MATH_ERREXCEPT)
+ if constexpr (__handle_fpexcept)
__flags |= 1;
#ifdef __FAST_MATH__
__flags |= 1 << 1;
next reply other threads:[~2022-01-17 10:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 10:21 Matthias Kretz [this message]
2022-01-17 10:23 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8121446.T7Z3S40VBb@minbar \
--to=m.kretz@gsi.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).