From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 64D0E3858D33 for ; Mon, 2 May 2022 07:57:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 64D0E3858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2B18C1F38C; Mon, 2 May 2022 07:57:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1651478265; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cZ0KQCk+NJkmtlvalLiElm8hYctYK4377HyJtEMgxM8=; b=SAXJNuhvbIsLSAn0d54THo7PMHZAKwzXl2YcsokKssDUp+xZzZtFZS6BdB/DCOOVV2gPD8 /iuVesKASup5dDvdr8lEK2hZoYRdv1HpFiMCbgvwJJO7JekA7mXxYGBfAJmkHnbjOMmFs9 B3wKY23zY+fTxpiWbQ6fI49+6tU/Ye8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1651478265; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cZ0KQCk+NJkmtlvalLiElm8hYctYK4377HyJtEMgxM8=; b=cluowGPo407zBPJRP06fKSGJvYRlV92+wlWG7Fw8qP/iJemNWHLoYUK6mS+KNZATpq6ZhX fbV8Ob0sAUICsRCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EE26E133E5; Mon, 2 May 2022 07:57:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IiaiOPiOb2JXAgAAMHmgww (envelope-from ); Mon, 02 May 2022 07:57:44 +0000 Message-ID: <8126b287-c55b-0e7a-032b-5211b4cfbbc2@suse.cz> Date: Mon, 2 May 2022 09:57:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] i386: simplify cpu_feature handling Content-Language: en-US From: =?UTF-8?Q?Martin_Li=c5=a1ka?= To: Jakub Jelinek Cc: Stefan Kneifel , gcc-patches@gcc.gnu.org References: <20211214102828.GU2646553@tucnak> <80d628c2-ea0d-c542-b0bb-399d83b7292d@suse.cz> <20211214161219.GX2646553@tucnak> <7d1f146e-b196-a5dd-b4b9-23d4ac68b572@suse.cz> <879ec827-1d81-dbdc-b978-a366d28eb175@suse.cz> In-Reply-To: <879ec827-1d81-dbdc-b978-a366d28eb175@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2022 07:57:47 -0000 On 3/31/22 09:01, Martin Liška wrote: > @Jakub: May I install it once stage1 opens? May I please ping this? Thanks, Martin > > Cheers, > Martin > > On 1/3/22 12:43, Martin Liška wrote: >> PING: Jakub? >> >> On 12/15/21 10:57, Martin Liška wrote: >>> On 12/14/21 17:12, Jakub Jelinek wrote: >>>> I'd use INT_TYPE_SIZE - 1 instead of 31.  Otherwise LGTM. >>> >>> Installed with that change, thanks. >>> >>> Moreover, I'm suggesting a simplification: >>> >>> The patch removes unneeded loops for cpu_features2 and CONVERT_EXPR >>> that can be simplified with NOP_EXPR. >>> >>> Survives i386.exp tests, may I install the patch after testing or >>> is it a stage1 material? >>> >>> Thanks, >>> Martin >> >