From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A42F23858C83 for ; Mon, 28 Feb 2022 15:30:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A42F23858C83 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-327-H7kFS_TkP-OrlO6-VQXoGw-1; Mon, 28 Feb 2022 10:30:32 -0500 X-MC-Unique: H7kFS_TkP-OrlO6-VQXoGw-1 Received: by mail-qk1-f199.google.com with SMTP id c19-20020a05620a11b300b00648cdeae21aso11296450qkk.17 for ; Mon, 28 Feb 2022 07:30:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=SsyckA7JZw+mgSx797+ktvKZnQGAMiPiWUR0kEXYdfs=; b=0emEacIhqzqVKxFV0gdXRoT2dJgmqogwRMScc72Efj+RVp+rGPYZIASjnkblznfqwB 3R5H4Q+AnGC0DPTfOEow0pZ511MK/dGt+7RmCFkYRqQ0oM4sAl96cc+ubl48BR0e3lRO kjOh1r57IHH0LjmJtuMW05It2MU4ZUmkpLFMF6ygl4b8MmoSOp2p0UBcnCwHdWtqf1Hh rXKlGKaQMIIGIqk3xjz1Cl8yZIttJbcaUQLqAMmdcAc2zH3bfzYALC08HOS3N3l7Pz7b JsBPjUc5IYPXufWYUFizDqOHAg92ROg1yJRbPsoORVf7nKCmsebSMq3p8Wy5CwUZYP+/ +wzA== X-Gm-Message-State: AOAM530VbII93jM8lOcb2RYPzoeGDqIWjDcyU85Uw5FYhzG01jnOdnkF UPoSofL4tOgHt2ZSEubdLHOdMf8F0beOhbA4OrkPiTZ/OpSrb1sda5S9PlDp7ZpEYKyxU9knVQU Dd/MAsCjm+iqcABb5Sg== X-Received: by 2002:a05:620a:13a9:b0:47c:cf9:b4c2 with SMTP id m9-20020a05620a13a900b0047c0cf9b4c2mr10841616qki.580.1646062228166; Mon, 28 Feb 2022 07:30:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJwfyzn8V4Vi/4wasC4e/z63GDvOSc/0JVJK6o4LZzVOVfZRVIh1FfTIo5D4CE8PO9tqcpTmdw== X-Received: by 2002:a05:620a:13a9:b0:47c:cf9:b4c2 with SMTP id m9-20020a05620a13a900b0047c0cf9b4c2mr10841598qki.580.1646062227870; Mon, 28 Feb 2022 07:30:27 -0800 (PST) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id 15-20020a37070f000000b0062cdc159505sm5129309qkh.89.2022.02.28.07.30.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 07:30:27 -0800 (PST) Message-ID: <815163c0f6c7272d8095496a429b5aa5be38eee8.camel@redhat.com> Subject: Re: [PATCH] Fix error recovery in toplev::finalize. From: David Malcolm To: Martin =?UTF-8?Q?Li=C5=A1ka?= , gcc-patches@gcc.gnu.org Date: Mon, 28 Feb 2022 10:30:26 -0500 In-Reply-To: <5d9fe598-1f3d-a756-2eab-d287cda5f46e@suse.cz> References: <5d9fe598-1f3d-a756-2eab-d287cda5f46e@suse.cz> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Feb 2022 15:30:34 -0000 On Mon, 2022-02-28 at 12:49 +0100, Martin Liška wrote: > Use flag_checking instead of CHECKING_P > and run toplev::finalize only if there is not error seen. > > Patch can bootstrap on x86_64-linux-gnu and survives regression > tests. Did the testing include the libgccjit test suite? ("jit" is not in -- enable-languages=all) > > Ready to be installed? I'm not keen on this change; IIRC it's valid to attempt to compile a gcc_jit_context that fails with an error, and then to attempt a different gcc_jit_context that succeeds, within the same process. If I'm reading the patch right, the patch as written removes this cleanup, which would thwart that. I can try to cook up a testcase for the above use case. Is there another way to fix PR 104648? Thanks Dave > Thanks, > Martin > >         PR ipa/104648 > > gcc/ChangeLog: > >         * main.cc (main): Use flag_checking instead of CHECKING_P >         and run toplev::finalize only if there is not error seen. > > gcc/testsuite/ChangeLog: > >         * g++.dg/pr104648.C: New test. > --- >   gcc/main.cc                     | 6 +++--- >   gcc/testsuite/g++.dg/pr104648.C | 9 +++++++++ >   2 files changed, 12 insertions(+), 3 deletions(-) >   create mode 100644 gcc/testsuite/g++.dg/pr104648.C > > diff --git a/gcc/main.cc b/gcc/main.cc > index f9dd6b2af58..4ba28b7de53 100644 > --- a/gcc/main.cc > +++ b/gcc/main.cc > @@ -37,9 +37,9 @@ main (int argc, char **argv) >                  true /* init_signals */); >   >     int r = toplev.main (argc, argv); > -#if CHECKING_P > -  toplev.finalize (); > -#endif > + > +  if (flag_checking && !seen_error ()) > +    toplev.finalize (); >   >     return r; >   } > diff --git a/gcc/testsuite/g++.dg/pr104648.C > b/gcc/testsuite/g++.dg/pr104648.C > new file mode 100644 > index 00000000000..b8b7c2864cf > --- /dev/null > +++ b/gcc/testsuite/g++.dg/pr104648.C > @@ -0,0 +1,9 @@ > +// { dg-do compile } > +// { dg-options "-fvtable-verify=preinit" } > + > +struct A {}; > +struct B : virtual A > +{ > +  B () {}; > +  B () {}; /* { dg-error "cannot be overloaded with" } */ > +};