From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12350 invoked by alias); 6 May 2018 01:19:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12331 invoked by uid 89); 6 May 2018 01:19:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-12.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=UD:tcc, H*r:ip*192.168.1.3, edward, HCc:U*gcc-patches X-HELO: omr-m010e.mx.aol.com Received: from omr-m010e.mx.aol.com (HELO omr-m010e.mx.aol.com) (204.29.186.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 06 May 2018 01:19:54 +0000 Received: from mtaout-mbd01.mx.aol.com (mtaout-mbd01.mx.aol.com [172.26.252.13]) by omr-m010e.mx.aol.com (Outbound Mail Relay) with ESMTP id 9D97738000B5; Sat, 5 May 2018 21:19:52 -0400 (EDT) Received: from [192.168.1.3] (0x5b3139322e3136382e312e335d [173.67.5.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mtaout-mbd01.mx.aol.com (MUA/Third Party Client Interface) with ESMTPSA id 5818838000089; Sat, 5 May 2018 21:19:52 -0400 (EDT) Subject: Re: [PATCH] PR libstdc++/80506 fix constant used in condition To: Jonathan Wakely , Paolo Carlini Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org, Vincent Poinot References: <20170424134316.GA16538@redhat.com> <5a44e474-356e-dbab-a1a4-548d4e049441@oracle.com> <9edaa145-40e6-6e71-cc6f-afa643281e67@oracle.com> <20170426091601.GI5109@redhat.com> From: Ed Smith-Rowland <3dw4rd@verizon.net> Message-ID: <81517154-e7a8-652e-eb65-3221b674a50b@verizon.net> Date: Sun, 06 May 2018 01:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20170426091601.GI5109@redhat.com> Content-Type: multipart/mixed; boundary="------------F8C16FD440A33B8ADAA80ED9" x-aol-global-disposition: G X-AOL-VSS-INFO: 5800.7501/128856 X-AOL-VSS-CODE: clean x-aol-sid: 3039ac1afc0d5aee58381c85 X-AOL-IP: 173.67.5.14 X-SW-Source: 2018-05/txt/msg00257.txt.bz2 This is a multi-part message in MIME format. --------------F8C16FD440A33B8ADAA80ED9 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 408 On 04/26/2017 05:16 AM, Jonathan Wakely wrote: > On 26/04/17 11:14 +0200, Paolo Carlini wrote: >> .. or maybe using the wrong constant only impacts the performance?!? > > Yes, I think so. I did some very simple sanity tests and the numbers > were identical before and after. > > > I was backporting this and saw that __generate_impl does this twice more. For trunk and branch-8 I have these patches. OK? --------------F8C16FD440A33B8ADAA80ED9 Content-Type: text/plain; charset=UTF-8; name="CL_pr80506" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="CL_pr80506" Content-length: 261 CjIwMTgtMDUtMDcgIEVkd2FyZCBTbWl0aC1Sb3dsYW5kICA8M2R3NHJkQHZl cml6b24ubmV0PgoKCU1vYXIgUFIgbGlic3RkYysrLzgwNTA2CgkqIGluY2x1 ZGUvYml0cy9yYW5kb20udGNjIChnYW1tYV9kaXN0cmlidXRpb246Ol9fZ2Vu ZXJhdGVfaW1wbCgpKToKCUZpeCBtYWdpYyBudW1iZXIgdXNlZCBpbiBsb29w IGNvbmRpdGlvbi4K --------------F8C16FD440A33B8ADAA80ED9 Content-Type: text/plain; charset=UTF-8; name="patch_pr80506" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch_pr80506" Content-length: 1107 SW5kZXg6IGluY2x1ZGUvYml0cy9yYW5kb20udGNjCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIGluY2x1ZGUvYml0cy9yYW5kb20udGNjCShyZXZpc2lv biAyNTk5NjUpCisrKyBpbmNsdWRlL2JpdHMvcmFuZG9tLnRjYwkod29ya2lu ZyBjb3B5KQpAQCAtMjQwOCw3ICsyNDA4LDcgQEAKIAkJICBfX3YgPSBfX3Yg KiBfX3YgKiBfX3Y7CiAJCSAgX191ID0gX19hdXJuZygpOwogCQl9Ci0JICAg ICAgd2hpbGUgKF9fdSA+IHJlc3VsdF90eXBlKDEuMCkgLSAwLjMzMSAqIF9f biAqIF9fbiAqIF9fbiAqIF9fbgorCSAgICAgIHdoaWxlIChfX3UgPiByZXN1 bHRfdHlwZSgxLjApIC0gMC4wMzMxICogX19uICogX19uICogX19uICogX19u CiAJCSAgICAgJiYgKHN0ZDo6bG9nKF9fdSkgPiAoMC41ICogX19uICogX19u ICsgX19hMQogCQkJCQkgICogKDEuMCAtIF9fdiArIHN0ZDo6bG9nKF9fdikp KSkpOwogCkBAIC0yNDI5LDcgKzI0MjksNyBAQAogCQkgIF9fdiA9IF9fdiAq IF9fdiAqIF9fdjsKIAkJICBfX3UgPSBfX2F1cm5nKCk7CiAJCX0KLQkgICAg ICB3aGlsZSAoX191ID4gcmVzdWx0X3R5cGUoMS4wKSAtIDAuMzMxICogX19u ICogX19uICogX19uICogX19uCisJICAgICAgd2hpbGUgKF9fdSA+IHJlc3Vs dF90eXBlKDEuMCkgLSAwLjAzMzEgKiBfX24gKiBfX24gKiBfX24gKiBfX24K IAkJICAgICAmJiAoc3RkOjpsb2coX191KSA+ICgwLjUgKiBfX24gKiBfX24g KyBfX2ExCiAJCQkJCSAgKiAoMS4wIC0gX192ICsgc3RkOjpsb2coX192KSkp KSk7CiAK --------------F8C16FD440A33B8ADAA80ED9--