* [PATCH] Fix building of cross compiler (PR target/81753).
@ 2017-08-15 13:56 Martin Liška
2017-08-15 16:24 ` Segher Boessenkool
2017-08-15 18:13 ` Mike Stump
0 siblings, 2 replies; 3+ messages in thread
From: Martin Liška @ 2017-08-15 13:56 UTC (permalink / raw)
To: gcc-patches; +Cc: Segher Boessenkool
[-- Attachment #1: Type: text/plain, Size: 338 bytes --]
Hi.
Simple fix for the PR where we wrongly combine extra_objs.
Ready to install the patch?
Thanks,
Martin
gcc/ChangeLog:
2017-08-15 Martin Liska <mliska@suse.cz>
PR target/81753
* config.gcc: Respect previously set extra_objs in case
of darwin target.
---
gcc/config.gcc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[-- Attachment #2: 0001-Fix-building-of-cross-compiler-PR-target-81753.patch --]
[-- Type: text/x-patch, Size: 431 bytes --]
diff --git a/gcc/config.gcc b/gcc/config.gcc
index 60f3d0ba141..7e024433160 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -653,7 +653,7 @@ case ${target} in
cxx_target_objs="${cxx_target_objs} darwin-c.o"
fortran_target_objs="darwin-f.o"
target_has_targetcm=yes
- extra_objs="darwin.o"
+ extra_objs="${extra_objs} darwin.o"
extra_gcc_objs="darwin-driver.o"
default_use_cxa_atexit=yes
use_gcc_stdint=wrap
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Fix building of cross compiler (PR target/81753).
2017-08-15 13:56 [PATCH] Fix building of cross compiler (PR target/81753) Martin Liška
@ 2017-08-15 16:24 ` Segher Boessenkool
2017-08-15 18:13 ` Mike Stump
1 sibling, 0 replies; 3+ messages in thread
From: Segher Boessenkool @ 2017-08-15 16:24 UTC (permalink / raw)
To: Martin Liška; +Cc: gcc-patches
Hi!
On Tue, Aug 15, 2017 at 03:35:36PM +0200, Martin Liška wrote:
> Simple fix for the PR where we wrongly combine extra_objs.
>
> Ready to install the patch?
Looks fine to me. This code is also for x86, but you could well
call this obvious and/or trivial :-) (Testing on x86 wouldn't
hurt of course).
Segher
> PR target/81753
> * config.gcc: Respect previously set extra_objs in case
> of darwin target.
> ---
> gcc/config.gcc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/gcc/config.gcc b/gcc/config.gcc
> index 60f3d0ba141..7e024433160 100644
> --- a/gcc/config.gcc
> +++ b/gcc/config.gcc
> @@ -653,7 +653,7 @@ case ${target} in
> cxx_target_objs="${cxx_target_objs} darwin-c.o"
> fortran_target_objs="darwin-f.o"
> target_has_targetcm=yes
> - extra_objs="darwin.o"
> + extra_objs="${extra_objs} darwin.o"
> extra_gcc_objs="darwin-driver.o"
> default_use_cxa_atexit=yes
> use_gcc_stdint=wrap
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Fix building of cross compiler (PR target/81753).
2017-08-15 13:56 [PATCH] Fix building of cross compiler (PR target/81753) Martin Liška
2017-08-15 16:24 ` Segher Boessenkool
@ 2017-08-15 18:13 ` Mike Stump
1 sibling, 0 replies; 3+ messages in thread
From: Mike Stump @ 2017-08-15 18:13 UTC (permalink / raw)
To: Martin Liška; +Cc: gcc-patches, Segher Boessenkool
On Aug 15, 2017, at 6:35 AM, Martin Liška <mliska@suse.cz> wrote:
>
> Simple fix for the PR where we wrongly combine extra_objs.
> Ready to install the patch?
Ok.
> PR target/81753
> * config.gcc: Respect previously set extra_objs in case
> of darwin target.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-15 17:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-15 13:56 [PATCH] Fix building of cross compiler (PR target/81753) Martin Liška
2017-08-15 16:24 ` Segher Boessenkool
2017-08-15 18:13 ` Mike Stump
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).