From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 249903858CD1 for ; Wed, 20 Dec 2023 18:50:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 249903858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 249903858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703098257; cv=none; b=oxp+Duget6d42Q2k1ATdqdgZvwVICzlxerCZVlQhUashQ35d192R0sXyfCJ3L6RB62X1EWgb9ACpo/krxrUnNNblryu0DuhihCyNYGS4jDrnAMfMnm4+13Nk6QV4dpZ5zI15Fufb/bWq+bCV3C5kI/qJ1CTEFmadQJAJaG6fb/0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703098257; c=relaxed/simple; bh=+tBTTJpEOtQ72q4x0Khd0vO9eMyWfiAqFg4ghQ/1K/E=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=MloUGIVUyEj/2iWoVISwD1zDS66XFedZ9o991kPK7BpvfdHgETlUE3IQBjIrDAhoWUYPee5BOGVHyVSmqbvT94EgFs0fN6VEMEQTBmK44k3Sv39Sb4mQrjdy9gUZvYQRcDb9TWF0MTC0FEUdH0uiV/0WmE1Thjre6XTEwUMtfuo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-35fbdcec131so9497245ab.0 for ; Wed, 20 Dec 2023 10:50:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703098254; x=1703703054; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uoXkfkcMdOqZkzuZh5LsnjYt0+K5VgT0d6RsCNT31oQ=; b=NrCwLny94c+i/XimfFRyWzjLxzeNivvQlKKrmLJ1IhnfpPAjEirIq/8oHbAN1lVoox ylvPrIknV29NAdmHInFLXzeEqoF3ye7YfguPlgRu3+9m7Ojc0pxQcA+gk7bjWkl+iP8L 9AEoZPuoBVmTbO/AuD+5N7Lu2xornzBqAJO2uVuKl481QOV/S0nAvzkf9gHcVhTjiRD1 9UszCY0SD/eNV8oMaLWtf/0BOQ91N3i3YmoyG5qPdrkZ6O2J3eFRsA8tbRu5QtQaHw3g xI11QbooTxBtZU86fTp97lR4OVaqDwt3BBgr9ZcxK0Ngk7Vao4DjYu9bgUFkXjI05q0U 3svg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703098254; x=1703703054; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uoXkfkcMdOqZkzuZh5LsnjYt0+K5VgT0d6RsCNT31oQ=; b=Lrlj+5GcEZr1i6Bdw7e2xZFI9yztBeZRIq5CHFwZr1RBkM3ZobiMGgd09ele/XCCa3 3dhoDFDu2LPM6r+eR5vIyxW6FNgYXqfxPVM06Dnmi9Jnv4e4/eTlyOQ7nFjUcjA59eOT sy/3JL56UEui0Y7LSbUQmRlSKBQPE972Dq6Z7sN0sYENFFVeh+j4LLmRdm4up9P5LWer nR+clznI470zabJCQtMDg8zi4hRmjAeW7mdR+cPrVunEhebDqMtmuoba2B7g1UvWZFXl 9THH3N8vu8x/PNiW9vIfzrecafHsBxUZSwcLZGWyttOteG0nN2v7oS3dpyWAhyAzV440 XcgQ== X-Gm-Message-State: AOJu0YwmAN8qOzIUG/47ODwOabCbe23gHbtgyDTC1wQd6vrRIINgRFXp gqT8d67J1xnKzFzz9fObNNA= X-Google-Smtp-Source: AGHT+IF+kg4zz8jhn4YX7QYa4SUJcZTF6rj86ehyUk9nRhpVauEILoKDHbFzLupPk2aks0nEJz0ucQ== X-Received: by 2002:a05:6e02:168a:b0:35f:c6ff:6a58 with SMTP id f10-20020a056e02168a00b0035fc6ff6a58mr2937705ila.50.1703098254308; Wed, 20 Dec 2023 10:50:54 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id m4-20020a92cac4000000b0035f753c0715sm30088ilq.33.2023.12.20.10.50.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 10:50:53 -0800 (PST) Message-ID: <819cc2ca-38ef-49dc-9d1e-e5af60ccd66b@gmail.com> Date: Wed, 20 Dec 2023 11:50:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3][RFC] RISC-V: Add non-vector types to pipelines Content-Language: en-US To: Edwin Lu , gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com, kito.cheng@gmail.com References: <20231215185328.794425-1-ewlu@rivosinc.com> <20231215185328.794425-2-ewlu@rivosinc.com> From: Jeff Law In-Reply-To: <20231215185328.794425-2-ewlu@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/15/23 11:53, Edwin Lu wrote: > This patch does not create vector related insn reservations for > generic.md and sifive-7.md. It updates/creates insn reservations > for all non-vector typed insns > > gcc/ChangeLog: > > * config/riscv/generic-ooo.md (generic_ooo_sfb_alu): create/update reservation > (generic_ooo_branch): ditto > * config/riscv/generic.md (generic_sfb_alu): ditto > * config/riscv/sifive-7.md (sifive_7_popcount): ditto > > Signed-off-by: Edwin Lu > --- > gcc/config/riscv/generic-ooo.md | 16 +++++++++++++--- > gcc/config/riscv/generic.md | 13 +++++++++---- > gcc/config/riscv/sifive-7.md | 12 +++++++++--- > 3 files changed, 31 insertions(+), 10 deletions(-) > > diff --git a/gcc/config/riscv/generic-ooo.md b/gcc/config/riscv/generic-ooo.md > index 78b9e48f935..de93245f965 100644 > --- a/gcc/config/riscv/generic-ooo.md > +++ b/gcc/config/riscv/generic-ooo.md > @@ -95,7 +95,7 @@ (define_insn_reservation "generic_ooo_float_store" 6 > ;; Vector load/store > (define_insn_reservation "generic_ooo_vec_load" 6 > (and (eq_attr "tune" "generic_ooo") > - (eq_attr "type" "vlde,vldm,vlds,vldux,vldox,vldff,vldr")) > + (eq_attr "type" "vlde,vldm,vlds,vldux,vldox,vldff,vldr,rdfrm")) > "generic_ooo_vxu_issue,generic_ooo_vxu_alu") Hmm, I don't think "rdfrm" is really a vector load. It's really a read of some bits in the fpcsr which elsewhere is handled as type fmove. I'd actually suggest fixing vector.md to use fmove on the appropriate insn, then dropping rdfrm entirely. > > (define_insn_reservation "generic_xfer" 3 > (and (eq_attr "tune" "generic") > - (eq_attr "type" "mfc,mtc,fcvt,fmove,fcmp")) > + (eq_attr "type" "mfc,mtc,fcvt,fmove,fcmp,cbo")) > "alu") cbo is probably closer to a load/store than it is a transfer operation. > > (define_insn_reservation "generic_branch" 1 > (and (eq_attr "tune" "generic") > - (eq_attr "type" "branch,jump,call,jalr")) > + (eq_attr "type" "branch,jump,call,jalr,ret,trap,pushpop")) > + "alu") pushpop are a mix of some pure memory operations and some mixed memory + branch. However, from a scheduling standpoint the branch isn't particularly interesting. So I'd have pushpop as a load/store. jeff