From: Edwin Lu <ewlu@rivosinc.com>
To: Jeff Law <jeffreyalaw@gmail.com>, gcc-patches@gcc.gnu.org
Cc: gnu-toolchain@rivosinc.com
Subject: Re: [Committed] RISC-V: Fix C23 (...) functions returning large aggregates [PR114175]
Date: Tue, 19 Mar 2024 09:57:48 -0700 [thread overview]
Message-ID: <819e5684-f3b0-454d-b133-a139425de27b@rivosinc.com> (raw)
In-Reply-To: <c9463224-54cc-428c-a892-6f89b18520a0@gmail.com>
On 3/18/2024 8:07 PM, Jeff Law wrote:
>
>
> On 3/18/24 12:54 PM, Edwin Lu wrote:
>> We assume that TYPE_NO_NAMED_ARGS_STDARG_P don't have any named
>> arguments and
>> there is nothing to advance, but that is not the case for (...)
>> functions
>> returning by hidden reference which have one such artificial argument.
>> This causes gcc.dg/c23-stdarg-[68].c to fail
>>
>> Fix the issue by checking if arg.type is NULL as r14-9503-g218d1749612
>> explains
>>
>> Tested on linux rv64gcv.
>>
>> gcc/ChangeLog:
>>
>> PR target/114175
>> * config/riscv/riscv.cc (riscv_setup_incoming_varargs): Only skip
>> riscv_funciton_arg_advance for TYPE_NO_NAMED_ARGS_STDARG_P functions
>> if arg.type is NULL
> OK. Thanks for taking care of this.
>
> Jeff
>
Committed!
Edwin
prev parent reply other threads:[~2024-03-19 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 18:54 [PATCH] " Edwin Lu
2024-03-19 3:07 ` Jeff Law
2024-03-19 16:57 ` Edwin Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=819e5684-f3b0-454d-b133-a139425de27b@rivosinc.com \
--to=ewlu@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).