From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id EA73F3858430 for ; Tue, 19 Mar 2024 16:57:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EA73F3858430 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EA73F3858430 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710867473; cv=none; b=ZtgXBkOYOBEeamn+1smecDR801GJTc/55NXfrqj3KZynAiOCOQu9gNFrOwrwe4hvjxAsqVgzwDVvvzmINE2OtBoCgFrFCRDfotydfRZGzpzdSoDz2ZiHNCCACfQGuQkReLPPoB+pB/O5QRw4mDgtDrXym1BEqbetOs4OBEUSgzY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710867473; c=relaxed/simple; bh=8mygdjSkw/Pjdt7fqcqYRlFqE+UNvwTpGsRUzAHKpXM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Z/puHFtPon92eMqRKsBcC6TbRN8Bgjhdz7/rSAXzXVgr79xvfuAV7otqtbtWDno7VoYzVLkP0X4LV/oERj27J8LGRR1/rS64SV5K/UHBVy2R0X4uLmR6Yqx2Ifqq42zd1ECmn4TNz/ZrPYTi6aSJc31dLIXfZaggWSXC4+LVPWI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-6e6cb0f782bso4945310b3a.1 for ; Tue, 19 Mar 2024 09:57:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1710867471; x=1711472271; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gB8N5shb1YgIy4XbGJAyT1gTmXdCX0wtPzf4FdQaBXQ=; b=fZid2r2jXtUKGy2J20n4njWAe/daIb3HkdBPKU2GX2l2YQtWlgXnMTdjd21SrA3HHn kw5AuZtklLpNxOhOA9Gf733NbjVmHGYtAX5Yz5pFNlgfQKo82qVWZCCvmEaehEkfp9va ftxifPdF+h3vVs5iNkoWfkKbce7IZYxxNJwdAgYvPFWrgzvzx3+Qsi5z3Jay8Dzzcn/8 bHlMUOQc4vSpqGNUBIIjMlt4UkTmlhRY/6qapDjokl9SM9QMm2WtOp9IQJvQyZ+zr4bt b7gB3yTttxi8JXVZ9rG+mWZhQQU61od0TStNxPcNnHtV/WBA1eHESkeKJdBmVISNRLiO uv9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710867471; x=1711472271; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gB8N5shb1YgIy4XbGJAyT1gTmXdCX0wtPzf4FdQaBXQ=; b=siccR5zFYPX9UzUFCq7GHgrH6sfDGsrlUGT5Xy0J43vJKwJspTGKn8iRnIL8Jcneig rMmqQpeHeCVm4JhRxj0BlQ1A0C1S6oWMO3wl9M2gXFBy9WPQ2rH481DIOFPhU/Ga/HZZ ynaUgBZ3TwVH/a7y/meyaOsDxT0WboUFip+K2h6duzullPvpofQEwwm+iSvR/GmavtDK KM93axiaOiGlrmITZekXf6psDJwD89NegrsmPPnK2QLtNEVcUIT28lzjEa8ZYBCtyNo7 w01mhUBXe8T5+3LXGl2g2U9/4BykJfi9tsa1blXR4DiGUPH5JXifet8diGwIo6+UG0Eu kNJQ== X-Forwarded-Encrypted: i=1; AJvYcCXRyAX62adjL+AxQTd3QnXcaH9HRhzCOYPtQwX6yU/huwo6I9pyLhWAFKCsXB3X7mTwNZuwSV/f8md9tC0/ueMTtDzGxPq0nQ== X-Gm-Message-State: AOJu0YwQhH3SvRZ5OQachUd4pImQ5zEGIqXA2pczNVCHcPq0j3RnNfdg 5PFh3U0o2PpiE00LldJEW3oc5tQNxVeLJpx8oma0GEX/vUJT5KQh9e7YZpugcNU= X-Google-Smtp-Source: AGHT+IH2wUuqGaYPh/bzV6godAikzZDSMdqSEkUGZ0QS5MiNZLyHwv5j2GuOqo+NkyHDGJp2kam6uw== X-Received: by 2002:a05:6a00:92a8:b0:6e6:9efe:68b6 with SMTP id jw40-20020a056a0092a800b006e69efe68b6mr4030705pfb.3.1710867470813; Tue, 19 Mar 2024 09:57:50 -0700 (PDT) Received: from [10.0.17.83] ([50.213.54.97]) by smtp.gmail.com with ESMTPSA id fn15-20020a056a002fcf00b006e091a254adsm9869069pfb.30.2024.03.19.09.57.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Mar 2024 09:57:50 -0700 (PDT) Message-ID: <819e5684-f3b0-454d-b133-a139425de27b@rivosinc.com> Date: Tue, 19 Mar 2024 09:57:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Committed] RISC-V: Fix C23 (...) functions returning large aggregates [PR114175] Content-Language: en-US To: Jeff Law , gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com References: <20240318185454.1314630-1-ewlu@rivosinc.com> From: Edwin Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/18/2024 8:07 PM, Jeff Law wrote: > > > On 3/18/24 12:54 PM, Edwin Lu wrote: >> We assume that TYPE_NO_NAMED_ARGS_STDARG_P don't have any named >> arguments and >> there is nothing to advance, but that is not the case for (...) >> functions >> returning by hidden reference which have one such artificial argument. >> This causes gcc.dg/c23-stdarg-[68].c to fail >> >> Fix the issue by checking if arg.type is NULL as r14-9503-g218d1749612 >> explains >> >> Tested on linux rv64gcv. >> >> gcc/ChangeLog: >> >>     PR target/114175 >>     * config/riscv/riscv.cc (riscv_setup_incoming_varargs): Only skip >>     riscv_funciton_arg_advance for TYPE_NO_NAMED_ARGS_STDARG_P functions >>     if arg.type is NULL > OK.  Thanks for taking care of this. > > Jeff > Committed! Edwin