From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129040 invoked by alias); 10 Feb 2020 20:52:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 128968 invoked by uid 89); 10 Feb 2020 20:52:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.8 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Feb 2020 20:52:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581367942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ywkItEoLXeSyAcoa7ou3tiwCMg0/OFecClKvP3bRu78=; b=KcmkWFywj8OMpBOfqGR9PIfJUPO2Hgx5+ikyoXVT3uemOQa88zvrE+hnKA5Jd81pQVK2gZ YPWcv6xOhq2VvWenmTJymDdYMbOgrGXZEEMq5Qxs+uci5gkyLkmoJjeYsm02z9RGqozzv7 /RYYyfuOsvmPE8TXLusobeAxBTO9D+w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-91-366HCk0kPnuNC0MgAzqjhg-1; Mon, 10 Feb 2020 15:52:15 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A6211800D55; Mon, 10 Feb 2020 20:52:14 +0000 (UTC) Received: from ovpn-116-56.phx2.redhat.com (ovpn-116-56.phx2.redhat.com [10.3.116.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id E84775D9CA; Mon, 10 Feb 2020 20:52:13 +0000 (UTC) Message-ID: <81d312e08e903fb93f4c0140672ad1efdc7053c2.camel@redhat.com> Subject: Re: [PATCH 1/2] analyzer: gfortran testsuite support From: David Malcolm To: sgk@troutmask.apl.washington.edu Cc: Toon Moene , gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Date: Mon, 10 Feb 2020 20:52:00 -0000 In-Reply-To: <20200210003821.GB64075@troutmask.apl.washington.edu> References: <20200206200144.14304-1-dmalcolm@redhat.com> <3fff5fee-8ac0-b3d1-f7cc-b0a2fb7f2754@moene.org> <20200209205511.GA63077@troutmask.apl.washington.edu> <023d55a415d2100dda16c8ddb6fe01ea5f598728.camel@redhat.com> <20200210003821.GB64075@troutmask.apl.washington.edu> User-Agent: Evolution 3.32.5 (3.32.5-1.fc30) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00589.txt.bz2 On Sun, 2020-02-09 at 16:38 -0800, Steve Kargl wrote: > On Sun, Feb 09, 2020 at 04:19:13PM -0500, David Malcolm wrote: > > On Sun, 2020-02-09 at 12:55 -0800, Steve Kargl wrote: > > > On Sun, Feb 09, 2020 at 09:15:46PM +0100, Toon Moene wrote: > > > > On 2/6/20 9:01 PM, David Malcolm wrote: > > > > > > > > > PR analyzer/93405 reports an ICE when attempting to use > > > > > -fanalyzer on > > > > > certain gfortran code. The second patch in this kit fixes > > > > > that, > > > > > but > > > > > in the meantime I need somewhere to put regression tests for > > > > > -fanalyzer > > > > > with gfortran. > > > > > > > > > > This patch adds a gfortran.dg/analyzer subdirectory with an > > > > > analyzer.exp, > > > > > setting DEFAULT_FFLAGS on the tests run within it. > > > > > > > > I have seen no objections against this proposal, so please go > > > > ahead. > > > > > > > > > > Perhaps, there are no objections because the people who > > > contribute > > > patches and provide reviews for gfortran have twindled to 1 or 2 > > > people > > > with sporadic available time. Did you actually review the > > > proposed > > > changes? If not, how can you rubber stamp this commit? You have > > > a > > > total of 12 ChangeLog entries over 18 years with the last > > > occurring > > > in > > > 2011, and I do not recall you ever reviewing a patch. > > > > FWIW Toon reported in BZ that patch 2 in the kit fixed the ICE he > > had > > reported, and I asked there if he was able to review this patch, > > which > > is what led to his email. > > > > I'm sorry if I overstepped the mark here. > > You didn't overstep the mark. I was questioning the manner in > which approval seem to be rubber stamped. > > > > Finally, trunk > > > is in stage 4 (regression fixes & docs only). This does not look > > > like > > > either. > > > > Indeed. The analyzer is a new feature in GCC 10. I'm hoping some > > latitude can be granted here given it's new (and hence all of its > > ICEs > > are, strictly speaking, not regressions), and this is about adding > > test > > coverage for fixing them. > > Having now looked at the patch, I think it's okay to commit. > As you note, it is new functionality in 10 so technically > cannot be a regression. But, it does fix an issue before > 10 is even released. > > OK to commit. Thanks. Is the Fortran testcase part of patch 2 OK as well? https://gcc.gnu.org/ml/gcc-patches/2020-02/msg00394.html Dave