From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by sourceware.org (Postfix) with ESMTPS id D59883858D1E for ; Sat, 11 Mar 2023 15:50:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D59883858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1034.google.com with SMTP id 6-20020a17090a190600b00237c5b6ecd7so12838248pjg.4 for ; Sat, 11 Mar 2023 07:50:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678549836; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Syd20hQf4OhYwNujejk2q5rxuvqbxYOIwt2R7lLyjH0=; b=LaRSb6ExsBlKNnDuEqHTIwLMw9gv7pFHZQQg9CMRmeKEZ7kKPSYqc0FrXtrWM8QpIc BDfJ6MgkwCnLq8WZ6SHTKx0FRirWjGi/Zy1olyAKWeG0O8bOy6WPTw//SMAapoIS/7c9 /PCUsn0iCnSiPOi7kwQ18Vfx08Uv7zuodrtjamhMUwoMx8N8hW+2YRJrVPy2XUUc+hWj nQLlHRE4NzXXAkZZy6/5DY45Wgk0wP6jcUFqZITxlb2sQ9mNHYopf/lf+XgXuhHi65Mk /wSHCS+7VZmS40Iqa/6tBcaBUqQsqbqQzd5iEfYfYIRIKDgsJxWxLw8LCGiEzH+3vlVc REZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678549836; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Syd20hQf4OhYwNujejk2q5rxuvqbxYOIwt2R7lLyjH0=; b=gKfnWoMKEdICLKThHOvPztlduuTiazZ7IU0GJs92uZcI2ZMPW/OYnGMVnUAvxAQZdm WGp3b3u5OZ1S5+4cweW87XpsBoeLPmzdcbEPmtb4WrHPylWP5+pQ6jOKjE8psUWsfyNt ZcoBa5oUqzuHNHNUFDEPylmkFaL5Bpzh2xMimEsHzwmZz7oMsqGWVUOKbjwnLLqk+Ass oJ2nTI1kw3cpjxe/5a8lf9fuLtQVedfh27EQhSgyEWdaP47Ai1JSicLJPZeyE+qS1v/p mHKaUkViV9ofORV9FJnaVykiVvM/myw2DIejiRKiDFEfKDHURm75VletIUcoDoPTKTio xkpA== X-Gm-Message-State: AO0yUKXzWS9pzQVgAYwyTFrSHmpqDBXIZkNwAEgIVGmPuzp92Gwg7Ar2 x6C56/T+n0IbP0pesll6Jgw= X-Google-Smtp-Source: AK7set/XK4XYcWboDPj3TbCpwbN+t7wgWtPU9Wa5mGmO4kR4xybD8hAqLAFuKwwpYrnwooHddMZOYw== X-Received: by 2002:a17:902:9b8a:b0:19a:acc2:73e4 with SMTP id y10-20020a1709029b8a00b0019aacc273e4mr24950223plp.22.1678549835665; Sat, 11 Mar 2023 07:50:35 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id lt18-20020a17090b355200b0022c0a05229fsm1682758pjb.41.2023.03.11.07.50.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Mar 2023 07:50:35 -0800 (PST) Message-ID: <81fe4dec-9dca-0041-13d2-5acc39ecab53@gmail.com> Date: Sat, 11 Mar 2023 08:50:33 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC PATCH v1 08/10] ifcvt: add if-conversion to conditional-zero instructions Content-Language: en-US To: "Maciej W. Rozycki" Cc: Philipp Tomsich , gcc-patches@gcc.gnu.org, Kito Cheng , Christoph Muellner , Palmer Dabbelt , Andrew Waterman , Vineet Gupta References: <20230210224150.2801962-1-philipp.tomsich@vrull.eu> <20230210224150.2801962-9-philipp.tomsich@vrull.eu> <90ef6883-397b-8e6a-1ecb-3663fe854ac7@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/28/23 09:42, Maciej W. Rozycki wrote: > On Mon, 13 Feb 2023, Jeff Law via Gcc-patches wrote: > >> 3. The canaonical conditional-zero-or-value assumes the target can do a >> generic SEQ/SNE of two register values. As you know, on RISC-V we have >> SEQZ/SNEZ. So we've added another fallback path to handle that case in >> noce_emit_condzero. You subtract the two values, then you can do an SEQZ/SNEZ >> on the result. > > NB these machine operations are identical to MIPSr6 SELEQZ and SELNEZ > instructions (cf. ISA_HAS_SEL), so why can't we just duplicate what the > MIPS backend does? Or did the MIPS backend do something wrong here? That's the form that Andrew (and subsequently I) both suggested using. Switching to that form may in turn make some of these other issues go away. jeff