From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-520708-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 8252 invoked by alias); 5 Mar 2020 13:52:02 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 8138 invoked by uid 89); 5 Mar 2020 13:52:01 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-9.8 required=5.0 tests=AWL,BAYES_00,KAM_COUK,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 spammy=H*f:sk:f327382, H*MI:sk:f327382, H*i:sk:f327382, HX-Languages-Length:1277
X-HELO: smtp1.wavenetuk.net
Received: from smtp.wavenetuk.net (HELO smtp1.wavenetuk.net) (195.26.36.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Mar 2020 13:51:59 +0000
Received: from [192.168.1.212] (host81-138-1-83.in-addr.btopenworld.com [81.138.1.83])	by smtp1.wavenetuk.net (Postfix) with ESMTPA id 129AB1200998;	Thu,  5 Mar 2020 13:51:57 +0000 (GMT)
Content-Type: text/plain; charset=utf-8; delsp=yes; format=flowed
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PING PATCH coroutines] Set side effects flag for BIND_EXPR which build in maybe_promote_captured_temps
From: Iain Sandoe <iain@sandoe.co.uk>
In-Reply-To: <f3273823-e10e-bf71-9f5e-b60464e2013b@linux.alibaba.com>
Date: Thu, 05 Mar 2020 13:52:00 -0000
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, Nathan Sidwell <nathan@acm.org>
Content-Transfer-Encoding: 8bit
Message-Id: <820841F1-826B-48EA-8AC2-2F7EC46987D9@sandoe.co.uk>
References: <8108a8fc-3ea4-6a3d-d018-5d8d3755cf5b@linux.alibaba.com> <d567541b-d7fe-d8e0-d7a7-d440a05b38de@linux.alibaba.com> <f3273823-e10e-bf71-9f5e-b60464e2013b@linux.alibaba.com>
To: JunMa <JunMa@linux.alibaba.com>
X-SW-Source: 2020-03/txt/msg00297.txt

Hello JunMa,

JunMa <JunMa@linux.alibaba.com> wrote:

> Ping

Thanks for your patch(es) and I am sorry this has taken some time to review.

(right now, we’re trying to ensure that we have the latest standard  
represented in
  GCC10, so updating to n4849).
>
> 在 2020/2/27 上午10:17, JunMa 写道:
>> 在 2020/2/11 上午10:50, JunMa 写道:
>> Hi
>> kindly ping~
>>
>> Regards
>> JunMa
>>> Hi
>>> As title. in maybe_promote_captured_temps, we promote captured  
>>> temporaries
>>> and co_await_expr into a new BIND_EXPR. As the BIND_EXPR contains
>>> co_await_expr and maybe other function calls, the side effects flag  
>>> should
>>> be set.
>>>
>>> This patch fix one mismatch in cppcoro, the testcase comes from cppcoro
>>> and is reduced by creduce.

With the following test conditions;

r10-7040-ga2ec7c4aafbcd517
  + the two approved patches by Bin Cheng applied.

  1/ the test case in this patch (lambda-10-co-await-lambda.C) fails both with and without the patch.
  2/ the patch regresses one of my local testcases.

So, it appears that the testcase might show a bug - but the fix is not the  
right one for current trunk?

Please could you re-check ?

thanks
Iain