public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Eric Botcazou <ebotcazou@adacore.com>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [patch] Fix EH breakage in LTO mode
Date: Thu, 09 Nov 2017 17:20:00 -0000	[thread overview]
Message-ID: <8209935.VjDLlsQAqs@polaris> (raw)
In-Reply-To: <20171109164224.GA17070@atrey.karlin.mff.cuni.cz>

> I am not sure I follow your argumentation here.  flag_exceptions is
> optimization which means that one should not test it globally. For that
> reason I would just change dwarf2out to simply trigger
> dwarf2out_frame_finish if any of the compiled functions needed it (had
> flag_exceptions set).

That's not sufficient for a partition with only EH-neutral functions.

> My readon of lto-wrapper is that it will set flag_exceptions for whole
> compilation unit when one of compilation units were copmiled with
> flag_exceptions.
> 
> How that helps the neutral functions?

flag_exceptions is never set in a partition with only EH-neutral functions.

-- 
Eric Botcazou

  reply	other threads:[~2017-11-09 16:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-09 16:39 Eric Botcazou
2017-11-09 16:51 ` Richard Biener
2017-11-09 17:17 ` Jan Hubicka
2017-11-09 17:20   ` Eric Botcazou [this message]
2017-11-09 18:12     ` Jan Hubicka
2017-11-09 20:03       ` Richard Biener
2017-11-09 23:43       ` Eric Botcazou
2017-11-09 18:03 ` Rainer Orth
2017-11-09 23:39   ` Eric Botcazou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8209935.VjDLlsQAqs@polaris \
    --to=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).