From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id E8E123858D28 for ; Mon, 28 Aug 2023 22:01:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E8E123858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1bdca7cc28dso29618485ad.1 for ; Mon, 28 Aug 2023 15:01:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693260115; x=1693864915; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NvuANElpASKnd2WVsNzIziCb1SDxVdHZvkf3PYEjSTM=; b=Pv5sHgkkkK5A3NXxF8KUFTU+LWE0iWUk6ry0snOdrHvOkj5VvMKx9XD7O5vLvQI5a3 x99bjeqLjf59flqZww7fkW0iyhOkQBw68Sp7hEYnl/k8GbbZjrWEiMUPz1Ni1rCZeZVo k0js4LZES2G5EuTl1wVQD4BHtoGueJbUpHGNTbEgY7fpDlhoQ9Zz6zFRHYdOdYG5cPiA 5YpFX4LeKRj2tWsciP1kP1eSk0RLLeIMAZB5Ro/LAyImm/UoK7616vMi3Psjjts1Kl1o judDtoFUi6Tn0jjNiVBZjBvuMZtL0gg2Vj1uh6o42cqXDl/KRmv3saTgM7hFR3inQN2E sRuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693260115; x=1693864915; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NvuANElpASKnd2WVsNzIziCb1SDxVdHZvkf3PYEjSTM=; b=g4J/b2suigA2UUkggf2YMJ2b8ZGULkTUKeBNh2hWEm+4v6wsGjjiXGmceeabY15Hz3 b0OZitSgSNoi5ePvkkUho/DFsC1iQdMdSbd876Ojtts6sg6mCKRe01HO79oOXOq1P8MN W6dGIVf3lpQFAoWnSaHe3cVRi32ZkrerQe5PPCJ/A8+6EhE9yf/vWk5ZERHrhICXfnWr hGWuIU8qa+ar7hAU9H+VuXZGYGw7vQ7FVYaC8OioggDM3toC7G8e6e4Mw36ynyh/5aDJ G1k+mf2MAI6Pkd8sIH5l2hQAA7kYiAiie6KlgDACZHrD3lVJ7XmlouuD4fbXfiCUt6F6 Tu1A== X-Gm-Message-State: AOJu0Yy23ufTw9uTZvDDEYnK//1hTLjLaKCYRWlsVW1FurFqlFRuTvjx fs/z7xc2TL+ykLtR2pCCSDzi0vAueNw= X-Google-Smtp-Source: AGHT+IGZFyDxrg7g7tzxj3Yoy7qDJjmvf1vBgzGKg0q2QCUyani9tu2MrrMpnfufsd4SqcC9tUjxfQ== X-Received: by 2002:a17:902:c947:b0:1c0:7bac:13d4 with SMTP id i7-20020a170902c94700b001c07bac13d4mr26165800pla.65.1693260114794; Mon, 28 Aug 2023 15:01:54 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id ik21-20020a170902ab1500b001afd821c057sm8022978plb.58.2023.08.28.15.01.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Aug 2023 15:01:54 -0700 (PDT) Message-ID: <8213c477-1339-c15a-5ae2-d4a920f38f20@gmail.com> Date: Mon, 28 Aug 2023 16:01:53 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] RISC-V: Revive test case PR 102957 Content-Language: en-US To: Tsukasa OI Cc: gcc-patches@gcc.gnu.org References: <3aa13843de038d960fdb3415f416243e43b376f2.1691745095.git.research_trasio@irq.a4lg.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/11/23 08:29, Tsukasa OI wrote: > On 2023/08/11 23:15, Jeff Law wrote: >> > > Originally, it tested that a two letter extension ('Zb') is accepted by > GCC (because the background of PR 102957 was GCC assumed multi-letter > 'Z' extensions are three letters or more). > > After rejecting unrecognized extensions, "dg-error" is added **just to > avoid the test failure** and that doesn't look right. Yes, we now don't > have an ICE (like in the original report) but after the PR 102957 fix, > we just accepted it, not rejecting it. > > Instead, we have a valid (recognized) two-letter 'Z' extension: 'Zk'. I > think replacing "zb" with "zk" is more correct considering the original > bug report (PR 102957) and its assumption. > > cf. Thanks. It still seems to me we want to have two tests here. I would suggest leaving pr102957.c alone since that tests that we give a proper error for "zb". Then create a new test that verifies "zk" is accepted without error. jeff