From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30196 invoked by alias); 28 Nov 2017 10:03:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30185 invoked by uid 89); 28 Nov 2017 10:03:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_BRBL_LASTEXT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1109 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Nov 2017 10:03:47 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 37D0581395; Tue, 28 Nov 2017 11:03:45 +0100 (CET) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rI4-B2szn0xX; Tue, 28 Nov 2017 11:03:45 +0100 (CET) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 151FF81339; Tue, 28 Nov 2017 11:03:45 +0100 (CET) From: Eric Botcazou To: Daniel Cederman Cc: gcc-patches@gcc.gnu.org, sebastian.huber@embedded-brains.de, daniel@gaisler.com Subject: Re: [PATCH v2 4/4] [SPARC] Errata workaround for GRLIB-TN-0013 Date: Tue, 28 Nov 2017 10:05:00 -0000 Message-ID: <8263671.7dDWPfLXbo@polaris> User-Agent: KMail/4.14.10 (Linux/3.16.7-53-desktop; KDE/4.14.9; x86_64; ; ) In-Reply-To: <20171127095715.5938-5-cederman@gaisler.com> References: <20171127095715.5938-1-cederman@gaisler.com> <20171127095715.5938-5-cederman@gaisler.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2017-11/txt/msg02383.txt.bz2 > 2017-11-17 Daniel Cederman > > * config/sparc/sparc.c (fpop_reg_depend_p): New function. > (div_sqrt_insn_p): New function. > (sparc_do_work_around_errata): Insert NOP instructions to > prevent sequences that could trigger the TN-0013 errata for > certain LEON3 processors. > (pass_work_around_errata::gate): Also test sparc_fix_tn0013. > (sparc_option_override): Set sparc_fix_tn0013 appropriately. > * config/sparc/sparc.md (fix_tn0013): New attribute. > (in_branch_delay): Prevent div and sqrt in delay slot if fix_tn0013. > * config/sparc/sparc.opt (sparc_fix_tn0013: New variable. OK for mainline and 7 branch modulo: > + /* Check if this is a problematic sequence. */ > + if (i > 1 > + && fp_found >= 2 > + && div_sqrt_insn_p (after)) > + { > + /* If is this is the short version of the problematic > + sequence we add two NOPs in a row to also prevent > + the long version. */ > + if (i == 2) > + emit_insn_before (gen_nop (), next); > + insert_nop = true; > + break; > + } Superfluous "is". -- Eric Botcazou