From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 36E623858D1E for ; Tue, 14 May 2024 05:14:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 36E623858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 36E623858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715663689; cv=none; b=wdqAfZk7lKHr7cBKZxX8jzolVdUNL1cDyDh/TQHs79qCbSI3LAEJX8gwgPLkcCLzVyyqGjRz4IZsfl1QqgO/gHyTcG//CdWSNYdHa8eBb0CInLbPMb5CmqqL9+CK8ZhwB7VVfDazhWZg0b5o2SejYrU4uy8gxptXRi2LXDpeRd0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715663689; c=relaxed/simple; bh=VmLL3tm0+6YgqLG7jzH3sW4uswp9Ore5ZAcfdp/RsWQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=NOVgGvTSWOhk2uZ2j+fAyJY4D1cK/obpj3LQfIqEQWi4JtwxK2+RSct2fR9SOmcesCxFjnGuHoZgAeqL5OmYrZMc2yakVLTzHLkUJdmJDccJ7AXm+XGvoNaUVJXj29x1rpB5uIzlad7sbUT7Vo+7jD3lZcRG8muBypXdoKMgQJk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 44E1UDoG021856; Tue, 14 May 2024 05:14:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : cc : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=Da+UbgBFrRqF4UEeeQIjr53TSQQNpOvVRGMcdsgyKEg=; b=QtJYsMhnzymHr955QTRb6nmchoHr4IdoeaJb9yizAOatQx8UDXokD4uYuq74I2+3i0Wj Ubr6vhc8uAnT35GIlPdTUElcdwAMDNLcN2B24A04OIEgD6WTtbwrMo2jFcaCeLubzQrK Y34//sHc4ElY27+L6P6ij5YAz/0gP9h1AFc+Dj1De1EmeOkY9AMp0rzjYQIAdzk9Vni8 vDTsUDyKO0ouhFTYwSM6G+xt3yLjlbBNULbwkch38OQdIui/Yh38G33Md/ZHvCMt/6ZV F5D6FE0JOle+Ma3xoLvwG34QNo+PEkdsAbCX490HRug2kt02YpURRN/I5iAiTri85feM GA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3y3wjs0f0s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 May 2024 05:14:44 +0000 Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 44E5EhUl021203; Tue, 14 May 2024 05:14:43 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3y3wjs0f0q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 May 2024 05:14:43 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 44E2KSBm029591; Tue, 14 May 2024 05:14:42 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3y2n7kk8tr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 May 2024 05:14:42 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 44E5EbFU38535428 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 May 2024 05:14:39 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 334FF20040; Tue, 14 May 2024 05:14:37 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5AB1D2004B; Tue, 14 May 2024 05:14:35 +0000 (GMT) Received: from [9.200.158.244] (unknown [9.200.158.244]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 14 May 2024 05:14:35 +0000 (GMT) Message-ID: <8271fd35-e882-66f1-92a2-b527d390686d@linux.ibm.com> Date: Tue, 14 May 2024 13:14:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 10/13] rs6000, extend vec_xxpermdi built-in for __int128 args Content-Language: en-US To: Carl Love References: <6378d560-df55-4b75-be7b-93dc6b85d81a@linux.ibm.com> <7290ea32-9e2f-41f4-9436-ea427ffe791b@linux.ibm.com> Cc: gcc-patches@gcc.gnu.org, "bergner@linux.ibm.com" , Segher Boessenkool , David Edelsohn From: "Kewen.Lin" In-Reply-To: <7290ea32-9e2f-41f4-9436-ea427ffe791b@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Fs69wm8UNx4bkOwTcAssNxbTPYL32PeM X-Proofpoint-ORIG-GUID: ZZRuAQr4aRwF1LDh_pnpdiBFpcOTdPsQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-14_01,2024-05-10_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 impostorscore=0 bulkscore=0 spamscore=0 phishscore=0 mlxlogscore=869 adultscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2405140033 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, on 2024/4/20 05:18, Carl Love wrote: > rs6000, extend vec_xxpermdi built-in for __int128 args > > Add a new overloaded instance for vec_xxpermdi > > __int128 vec_xxpermdi (__int128, __int128, const int); > > Update the documentation to include a reference to the new built-in > instance. > > gcc/ChangeLog: > * config/rs6000/rs6000-builtins.def (vec_xxpermdi): Add new > overloaded built-in instance. > --- > gcc/config/rs6000/rs6000-overload.def | 2 ++ > gcc/doc/extend.texi | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/gcc/config/rs6000/rs6000-overload.def b/gcc/config/rs6000/rs6000-overload.def > index 5912c9452f4..49962e2f2a2 100644 > --- a/gcc/config/rs6000/rs6000-overload.def > +++ b/gcc/config/rs6000/rs6000-overload.def > @@ -4932,6 +4932,8 @@ > XXPERMDI_4SF XXPERMDI_VF > vd __builtin_vsx_xxpermdi (vd, vd, const int); > XXPERMDI_2DF XXPERMDI_VD > + vsq __builtin_vsx_xxpermdi (vsq, vsq, const int); > + XXPERMDI_1TI XXPERMDI_1TI This actually introduces the signed __int128, considering the other existing ones, I think we want both signed and unsigned. > > [VEC_XXSLDWI, vec_xxsldwi, __builtin_vsx_xxsldwi] > vsc __builtin_vsx_xxsldwi (vsc, vsc, const int); > diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi > index 86b8e536dbe..47cf2f3bc8b 100644 > --- a/gcc/doc/extend.texi > +++ b/gcc/doc/extend.texi > @@ -22505,6 +22505,7 @@ void vec_vsx_st (vector bool char, int, vector bool char *); > void vec_vsx_st (vector bool char, int, unsigned char *); > void vec_vsx_st (vector bool char, int, signed char *); > > +vector __int128 vec_xxpermdi (vector __int128, vector __int128, const int); > vector double vec_xxpermdi (vector double, vector double, const int); > vector float vec_xxpermdi (vector float, vector float, const int); Nit: Considering the existing ones sorted by element size descending, I guess it's better to move the above here (and with the explicit signed and unsigned). And we need a test case for it as well? BR, Kewen > vector long long vec_xxpermdi (vector long long, vector long long, const int);